| Message ID | 20220817095725.97444-1-maxime.chevallier@bootlin.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fb8d784b531e363171c7e22f4f0980b4b128a607 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ethernet: altera: Add use of ethtool_op_get_ts_info | expand |
On Wed, 17 Aug 2022 11:57:25 +0200 Maxime Chevallier wrote: > Add the ethtool_op_get_ts_info() callback to ethtool ops, so that we can > at least use software timestamping. > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> I think our definition of bug is too narrow to fit this. It falls into "never worked" category AFAICT so to net-next it goes.
Hello Jakub, On Thu, 18 Aug 2022 10:26:56 -0700 Jakub Kicinski <kuba@kernel.org> wrote: > On Wed, 17 Aug 2022 11:57:25 +0200 Maxime Chevallier wrote: > > Add the ethtool_op_get_ts_info() callback to ethtool ops, so that > > we can at least use software timestamping. > > > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > > I think our definition of bug is too narrow to fit this. It falls into > "never worked" category AFAICT so to net-next it goes. My bad, I actually meant to target it to net-next, that was a silly mistake from me... Do I need to resend ? Best regards, Maxime
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 17 Aug 2022 11:57:25 +0200 you wrote: > Add the ethtool_op_get_ts_info() callback to ethtool ops, so that we can > at least use software timestamping. > > Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> > --- > drivers/net/ethernet/altera/altera_tse_ethtool.c | 1 + > 1 file changed, 1 insertion(+) Here is the summary with links: - [net] net: ethernet: altera: Add use of ethtool_op_get_ts_info https://git.kernel.org/netdev/net-next/c/fb8d784b531e You are awesome, thank you!
diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c b/drivers/net/ethernet/altera/altera_tse_ethtool.c index 4299f1301149..3081e5874ac5 100644 --- a/drivers/net/ethernet/altera/altera_tse_ethtool.c +++ b/drivers/net/ethernet/altera/altera_tse_ethtool.c @@ -233,6 +233,7 @@ static const struct ethtool_ops tse_ethtool_ops = { .set_msglevel = tse_set_msglevel, .get_link_ksettings = phy_ethtool_get_link_ksettings, .set_link_ksettings = phy_ethtool_set_link_ksettings, + .get_ts_info = ethtool_op_get_ts_info, }; void altera_tse_set_ethtool_ops(struct net_device *netdev)
Add the ethtool_op_get_ts_info() callback to ethtool ops, so that we can at least use software timestamping. Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com> --- drivers/net/ethernet/altera/altera_tse_ethtool.c | 1 + 1 file changed, 1 insertion(+)