| Message ID | 20220818210228.8635-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 92f24c6fefd53c251c3fa1f09b94871ac385cfdd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net_sched: move from strlcpy with unused retval to strscpy | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 18 Aug 2022 23:02:28 +0200 you wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > [...] Here is the summary with links: - net_sched: move from strlcpy with unused retval to strscpy https://git.kernel.org/netdev/net-next/c/92f24c6fefd5 You are awesome, thank you!
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c index bf87b50837a8..5b229c7e0065 100644 --- a/net/sched/sch_api.c +++ b/net/sched/sch_api.c @@ -194,7 +194,7 @@ EXPORT_SYMBOL(unregister_qdisc); void qdisc_get_default(char *name, size_t len) { read_lock(&qdisc_mod_lock); - strlcpy(name, default_qdisc_ops->id, len); + strscpy(name, default_qdisc_ops->id, len); read_unlock(&qdisc_mod_lock); } diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index 6af6b95bdb67..1f447b77ce84 100644 --- a/net/sched/sch_teql.c +++ b/net/sched/sch_teql.c @@ -492,7 +492,7 @@ static int __init teql_init(void) master = netdev_priv(dev); - strlcpy(master->qops.id, dev->name, IFNAMSIZ); + strscpy(master->qops.id, dev->name, IFNAMSIZ); err = register_qdisc(&master->qops); if (err) {
Follow the advice of the below link and prefer 'strscpy' in this subsystem. Conversion is 1:1 because the return value is not used. Generated by a coccinelle script. Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- net/sched/sch_api.c | 2 +- net/sched/sch_teql.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)