| Message ID | 20220906065815.3856323-1-casper.casan@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 75554fe00f941c3c3d9344e88708093a14d2b4b8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] net: sparx5: fix function return type to match actual type | expand |
On Tue, Sep 06, 2022 at 08:58:15AM +0200, Casper Andersson wrote: > Function returns error integer, not bool. > > Does not have any impact on functionality. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Casper Andersson <casper.casan@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (master) by Paolo Abeni <pabeni@redhat.com>: On Tue, 6 Sep 2022 08:58:15 +0200 you wrote: > Function returns error integer, not bool. > > Does not have any impact on functionality. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Casper Andersson <casper.casan@gmail.com> > > [...] Here is the summary with links: - [v2,net-next] net: sparx5: fix function return type to match actual type https://git.kernel.org/netdev/net-next/c/75554fe00f94 You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c b/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c index a5837dbe0c7e..4af285918ea2 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c @@ -186,8 +186,8 @@ bool sparx5_mact_getnext(struct sparx5 *sparx5, return ret == 0; } -bool sparx5_mact_find(struct sparx5 *sparx5, - const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2) +int sparx5_mact_find(struct sparx5 *sparx5, + const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2) { int ret; u32 cfg2; diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h index 9b4395b7a9e4..8b42cad0e49c 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h @@ -321,8 +321,8 @@ int sparx5_mact_learn(struct sparx5 *sparx5, int port, const unsigned char mac[ETH_ALEN], u16 vid); bool sparx5_mact_getnext(struct sparx5 *sparx5, unsigned char mac[ETH_ALEN], u16 *vid, u32 *pcfg2); -bool sparx5_mact_find(struct sparx5 *sparx5, - const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2); +int sparx5_mact_find(struct sparx5 *sparx5, + const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2); int sparx5_mact_forget(struct sparx5 *sparx5, const unsigned char mac[ETH_ALEN], u16 vid); int sparx5_add_mact_entry(struct sparx5 *sparx5,
Function returns error integer, not bool. Does not have any impact on functionality. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Casper Andersson <casper.casan@gmail.com> --- Sorry Dan, I forgot to include you in the first version. drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c | 4 ++-- drivers/net/ethernet/microchip/sparx5/sparx5_main.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)