From patchwork Tue Sep 6 06:58:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Casper Andersson X-Patchwork-Id: 12966939 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1F9ECAAA1 for ; Tue, 6 Sep 2022 06:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232957AbiIFG62 (ORCPT ); Tue, 6 Sep 2022 02:58:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233321AbiIFG61 (ORCPT ); Tue, 6 Sep 2022 02:58:27 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 256B772FEB for ; Mon, 5 Sep 2022 23:58:26 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id x10so11263460ljq.4 for ; Mon, 05 Sep 2022 23:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:organization:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date; bh=D3Hllf81lTvXZZowRJzBDAczHqiEfwobrdq5tqmcJxs=; b=FFYqu+lwDnEiVXwnsyfgtpusn5+yaSIAzbl/IJqx3D1pw5Hsmpd3SyUxukKyFslAgk HSn2AEA2Pe7TX4RKEZpNimnuAFNpZESDMiKS1E8WT6SonHRYEmmdxTZdU3n/nReP+BzF blb7FppsNkasWkKP77mzC5LRq7v+BTRMxYnUhsuJbmzphrH0CTC4nu+HNWWeWezIaWyA O+RiDKtPxIdXwG/baq6Z2GHJWAnXrZ5/71xd98Q91nTT9QJqfMQ8Br4xfMR5hnq8e5Ue O2fI8iitwu26ZWlQz/KeZrb+3myYQis8GkRmc6+uBijvj9Sp/ki2xU/WWVX2A+w3ATjx A/lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:organization:mime-version:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=D3Hllf81lTvXZZowRJzBDAczHqiEfwobrdq5tqmcJxs=; b=g6TiZCNyn2IdSHleUpKpLnvC556hZaPVE6z0t+a5LVOPvZ0MaZkrVGCUP7Z++vm8uC kxD6IQPQE4ac4yltVs/qqanKcH1i2RVjm7GABJWjSmocQHJeob3FGkjkww/apuy8bFHT 1n5Ve7jB+Lj2IE1azmiQqrOQ3O4MJOznzVzsipX3rfU2TAfMNp/82TJip9mJ4nbNYIyE RHFld0q1h1pz9ibmxkjVHVVKr2sKLbYlC+dczxgAh5ubOQj0GWU9/27ltfwLFhLyRtDd c46KV6yVl/029E0Mpo9F1YToL1NGjvVSGW1eh1c0VyrMUV/8NVt081dt2utmbzkClVps yh7Q== X-Gm-Message-State: ACgBeo0fanyA3HQPEobUVVfYLA4qTAVafAeotOFZw0oatVLaK9w60JEh 2RsIA25hR/P1Oezmti4g5Ik= X-Google-Smtp-Source: AA6agR4oClcKHKlMdoD3lJTYWz+HGIHPHZzoaW9mJPT7eAJjsK2uxj91DKe5JJkU3KrhYTR3jCP8Jw== X-Received: by 2002:a2e:9f50:0:b0:267:7e8e:5396 with SMTP id v16-20020a2e9f50000000b002677e8e5396mr9308269ljk.222.1662447504408; Mon, 05 Sep 2022 23:58:24 -0700 (PDT) Received: from wse-c0155.labs.westermo.se (static-193-12-47-89.cust.tele2.se. [193.12.47.89]) by smtp.gmail.com with ESMTPSA id b23-20020a056512071700b0049600497ed1sm1027464lfs.26.2022.09.05.23.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Sep 2022 23:58:23 -0700 (PDT) From: Casper Andersson To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Casper Andersson , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, Dan Carpenter Subject: [PATCH v2 net-next] net: sparx5: fix function return type to match actual type Date: Tue, 6 Sep 2022 08:58:15 +0200 Message-Id: <20220906065815.3856323-1-casper.casan@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Organization: Westermo Network Technologies AB Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Function returns error integer, not bool. Does not have any impact on functionality. Reported-by: Dan Carpenter Signed-off-by: Casper Andersson Reviewed-by: Andrew Lunn --- Sorry Dan, I forgot to include you in the first version. drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c | 4 ++-- drivers/net/ethernet/microchip/sparx5/sparx5_main.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c b/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c index a5837dbe0c7e..4af285918ea2 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_mactable.c @@ -186,8 +186,8 @@ bool sparx5_mact_getnext(struct sparx5 *sparx5, return ret == 0; } -bool sparx5_mact_find(struct sparx5 *sparx5, - const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2) +int sparx5_mact_find(struct sparx5 *sparx5, + const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2) { int ret; u32 cfg2; diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h index 9b4395b7a9e4..8b42cad0e49c 100644 --- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h @@ -321,8 +321,8 @@ int sparx5_mact_learn(struct sparx5 *sparx5, int port, const unsigned char mac[ETH_ALEN], u16 vid); bool sparx5_mact_getnext(struct sparx5 *sparx5, unsigned char mac[ETH_ALEN], u16 *vid, u32 *pcfg2); -bool sparx5_mact_find(struct sparx5 *sparx5, - const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2); +int sparx5_mact_find(struct sparx5 *sparx5, + const unsigned char mac[ETH_ALEN], u16 vid, u32 *pcfg2); int sparx5_mact_forget(struct sparx5 *sparx5, const unsigned char mac[ETH_ALEN], u16 vid); int sparx5_add_mact_entry(struct sparx5 *sparx5,