| Message ID | 20220913144406.2002409-1-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next,1/3] net: dsa: microchip: remove unnecessary spi_set_drvdata() | expand |
On Tue, Sep 13, 2022 at 10:44:04PM +0800, Yang Yingliang wrote: > Remove unnecessary spi_set_drvdata() in ksz_spi_remove(), the > driver_data will be set to NULL in device_unbind_cleanup() after > calling ->remove(). > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- I would like all drivers in drivers/net/dsa/ to follow the same convention, which they currently do. They all call .*_set_drvdata.*NULL from ->remove(), why just patch the spi_set_drvdata() calls?
Hi Vladimir, On 2022/9/21 7:45, Vladimir Oltean wrote: > On Tue, Sep 13, 2022 at 10:44:04PM +0800, Yang Yingliang wrote: >> Remove unnecessary spi_set_drvdata() in ksz_spi_remove(), the >> driver_data will be set to NULL in device_unbind_cleanup() after >> calling ->remove(). >> >> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >> --- > I would like all drivers in drivers/net/dsa/ to follow the same > convention, which they currently do. They all call .*_set_drvdata.*NULL > from ->remove(), why just patch the spi_set_drvdata() calls? Yes, it's right, all the set_drvdata functions in ->remove() can be removed. I will send a v2 to remove all this calling. Thanks, Yang > .
diff --git a/drivers/net/dsa/microchip/ksz_spi.c b/drivers/net/dsa/microchip/ksz_spi.c index 82e2352f55fa..1b6ab891b986 100644 --- a/drivers/net/dsa/microchip/ksz_spi.c +++ b/drivers/net/dsa/microchip/ksz_spi.c @@ -107,8 +107,6 @@ static void ksz_spi_remove(struct spi_device *spi) if (dev) ksz_switch_remove(dev); - - spi_set_drvdata(spi, NULL); } static void ksz_spi_shutdown(struct spi_device *spi)
Remove unnecessary spi_set_drvdata() in ksz_spi_remove(), the driver_data will be set to NULL in device_unbind_cleanup() after calling ->remove(). Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/dsa/microchip/ksz_spi.c | 2 -- 1 file changed, 2 deletions(-)