| Message ID | 20220914140100.3795545-2-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 13c76227cd8a14c5aa092387575cc3cab8eba5b4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next,v2,1/2] net/mlx5e: add missing error code in error path | expand |
On 14 Sep 22:01, Yang Yingliang wrote: >Use kmemdup() helper instead of open-coding to >simplify the code when allocate dev_addr. > >Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> >--- >v2: > Make kmemdup() fit in one line. >--- Acked-by: Saeed Mahameed <saeedm@nvidia.com> netdev maintainers please apply directly. Thanks.
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 100e03eb740b..ea362072a984 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -931,14 +931,13 @@ static int mlx5e_macsec_add_secy(struct macsec_context *ctx) goto out; } - macsec_device->dev_addr = kzalloc(dev->addr_len, GFP_KERNEL); + macsec_device->dev_addr = kmemdup(dev->dev_addr, dev->addr_len, GFP_KERNEL); if (!macsec_device->dev_addr) { kfree(macsec_device); err = -ENOMEM; goto out; } - memcpy(macsec_device->dev_addr, dev->dev_addr, dev->addr_len); macsec_device->netdev = dev; INIT_LIST_HEAD_RCU(&macsec_device->macsec_rx_sc_list_head);
Use kmemdup() helper instead of open-coding to simplify the code when allocate dev_addr. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- v2: Make kmemdup() fit in one line. --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)