| Message ID | 20220915030201.35984-1-yuanjilin@cdjrlc.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | orinoco: fix repeated words in comments | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 9/14/2022 8:02 PM, Jilin Yuan wrote: > Delete the redundant word 'this'. > > Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> > --- > drivers/net/wireless/intersil/orinoco/main.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intersil/orinoco/main.h b/drivers/net/wireless/intersil/orinoco/main.h > index 5a8fec26136e..852e1643dad2 100644 > --- a/drivers/net/wireless/intersil/orinoco/main.h > +++ b/drivers/net/wireless/intersil/orinoco/main.h > @@ -12,7 +12,7 @@ > /* Compile time configuration and compatibility stuff */ > /********************************************************************/ > > -/* We do this this way to avoid ifdefs in the actual code */ > +/* We do this way to avoid ifdefs in the actual code */ In this case the two instances of "this" are not a repetition, they are different parts of speech. The existing sentence is correct English; the modified sentence is not. If the repeated word really bothers you then insert "in": We do this in this way... > #ifdef WIRELESS_SPY > #define SPY_NUMBER(priv) (priv->spy_data.spy_number) > #else
On 9/14/2022 8:54 PM, Jeff Johnson wrote: > On 9/14/2022 8:02 PM, Jilin Yuan wrote: >> Delete the redundant word 'this'. >> >> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> >> --- >> drivers/net/wireless/intersil/orinoco/main.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/intersil/orinoco/main.h >> b/drivers/net/wireless/intersil/orinoco/main.h >> index 5a8fec26136e..852e1643dad2 100644 >> --- a/drivers/net/wireless/intersil/orinoco/main.h >> +++ b/drivers/net/wireless/intersil/orinoco/main.h >> @@ -12,7 +12,7 @@ >> /* Compile time configuration and compatibility stuff */ >> /********************************************************************/ >> -/* We do this this way to avoid ifdefs in the actual code */ >> +/* We do this way to avoid ifdefs in the actual code */ > > In this case the two instances of "this" are not a repetition, they are > different parts of speech. > > The existing sentence is correct English; the modified sentence is not. > > If the repeated word really bothers you then insert "in": We do this in > this way... > > >> #ifdef WIRELESS_SPY >> #define SPY_NUMBER(priv) (priv->spy_data.spy_number) >> #else > In addition the patch subject of all files in drivers/net/wireless should now begin with "wifi: "
diff --git a/drivers/net/wireless/intersil/orinoco/main.h b/drivers/net/wireless/intersil/orinoco/main.h index 5a8fec26136e..852e1643dad2 100644 --- a/drivers/net/wireless/intersil/orinoco/main.h +++ b/drivers/net/wireless/intersil/orinoco/main.h @@ -12,7 +12,7 @@ /* Compile time configuration and compatibility stuff */ /********************************************************************/ -/* We do this this way to avoid ifdefs in the actual code */ +/* We do this way to avoid ifdefs in the actual code */ #ifdef WIRELESS_SPY #define SPY_NUMBER(priv) (priv->spy_data.spy_number) #else
Delete the redundant word 'this'. Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com> --- drivers/net/wireless/intersil/orinoco/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)