| Message ID | 20220915065043.665138-2-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 770aac8dc05de86d3e56d8fa5a47d74c0d9ca50f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next,1/3] net: mdio: mux-meson-g12a: Switch to use dev_err_probe() helper | expand |
On Thu, Sep 15, 2022 at 02:50:42PM +0800, Yang Yingliang wrote: > dev_err() can be replace with dev_err_probe() which will check if error > code is -EPROBE_DEFER. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/mdio/mdio-mux-mmioreg.c b/drivers/net/mdio/mdio-mux-mmioreg.c index c02fb2a067ee..c02c9c660016 100644 --- a/drivers/net/mdio/mdio-mux-mmioreg.c +++ b/drivers/net/mdio/mdio-mux-mmioreg.c @@ -159,12 +159,9 @@ static int mdio_mux_mmioreg_probe(struct platform_device *pdev) ret = mdio_mux_init(&pdev->dev, pdev->dev.of_node, mdio_mux_mmioreg_switch_fn, &s->mux_handle, s, NULL); - if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, - "failed to register mdio-mux bus %pOF\n", np); - return ret; - } + if (ret) + return dev_err_probe(&pdev->dev, ret, + "failed to register mdio-mux bus %pOF\n", np); pdev->dev.platform_data = s;
dev_err() can be replace with dev_err_probe() which will check if error code is -EPROBE_DEFER. Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/mdio/mdio-mux-mmioreg.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)