| Message ID | 20220921090455.752011-3-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Remove useless inline functions from net | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessed tree name to be net-next, async |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 7 this patch: 7 |
| netdev/cc_maintainers | success | CCed 15 of 15 maintainers |
| netdev/build_clang | success | Errors and warnings before: 4 this patch: 4 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 7 this patch: 7 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 12 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Wed, 21 Sep 2022 17:04:52 +0800 Gaosheng Cui wrote: > All uses of mt76_wcid_mask_test() have > been removed since commit 8950a62f19c9 ("mt76: get rid of > mt76_wcid_hw routine"), so remove it. This should go via the wireless tree, please take it out of this series and send it to linux-wireless separately.
On 9/21/2022 6:11 AM, Jakub Kicinski wrote: > On Wed, 21 Sep 2022 17:04:52 +0800 Gaosheng Cui wrote: >> All uses of mt76_wcid_mask_test() have >> been removed since commit 8950a62f19c9 ("mt76: get rid of >> mt76_wcid_hw routine"), so remove it. > > This should go via the wireless tree, please take it out of this series > and send it to linux-wireless separately. And when you do that add wifi: prefix to the subject
> On 9/21/2022 6:11 AM, Jakub Kicinski wrote: >> On Wed, 21 Sep 2022 17:04:52 +0800 Gaosheng Cui wrote: >>> All uses of mt76_wcid_mask_test() have >>> been removed since commit 8950a62f19c9 ("mt76: get rid of >>> mt76_wcid_hw routine"), so remove it. >> >> This should go via the wireless tree, please take it out of this series >> and send it to linux-wireless separately. > > And when you do that add wifi: prefix to the subject > . Thanks for taking time to review this patch, I have made a patch v2 and submitted it. link: https://lore.kernel.org/netdev/20220922074711.1408385-1-cuigaosheng1@huawei.com/
diff --git a/drivers/net/wireless/mediatek/mt76/util.h b/drivers/net/wireless/mediatek/mt76/util.h index 49c52d781f40..260965dde94c 100644 --- a/drivers/net/wireless/mediatek/mt76/util.h +++ b/drivers/net/wireless/mediatek/mt76/util.h @@ -29,12 +29,6 @@ enum { int mt76_wcid_alloc(u32 *mask, int size); -static inline bool -mt76_wcid_mask_test(u32 *mask, int idx) -{ - return mask[idx / 32] & BIT(idx % 32); -} - static inline void mt76_wcid_mask_set(u32 *mask, int idx) {
All uses of mt76_wcid_mask_test() have been removed since commit 8950a62f19c9 ("mt76: get rid of mt76_wcid_hw routine"), so remove it. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- drivers/net/wireless/mediatek/mt76/util.h | 6 ------ 1 file changed, 6 deletions(-)