| Message ID | 20220921092734.31700-1-hbh25y@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c2e1cfefcac35e0eea229e148c8284088ce437b5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] net: sched: fix possible refcount leak in tc_new_tfilter() | expand |
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 21 Sep 2022 17:27:34 +0800 you wrote: > tfilter_put need to be called to put the refount got by tp->ops->get to > avoid possible refcount leak when chain->tmplt_ops != NULL and > chain->tmplt_ops != tp->ops. > > Fixes: 7d5509fa0d3d ("net: sched: extend proto ops with 'put' callback") > Signed-off-by: Hangyu Hua <hbh25y@gmail.com> > Reviewed-by: Vlad Buslov <vladbu@nvidia.com> > > [...] Here is the summary with links: - [v2] net: sched: fix possible refcount leak in tc_new_tfilter() https://git.kernel.org/netdev/net/c/c2e1cfefcac3 You are awesome, thank you!
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 790d6809be81..51d175f3fbcb 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -2137,6 +2137,7 @@ static int tc_new_tfilter(struct sk_buff *skb, struct nlmsghdr *n, } if (chain->tmplt_ops && chain->tmplt_ops != tp->ops) { + tfilter_put(tp, fh); NL_SET_ERR_MSG(extack, "Chain template is set to a different filter kind"); err = -EINVAL; goto errout;
tfilter_put need to be called to put the refount got by tp->ops->get to avoid possible refcount leak when chain->tmplt_ops != NULL and chain->tmplt_ops != tp->ops. Fixes: 7d5509fa0d3d ("net: sched: extend proto ops with 'put' callback") Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Reviewed-by: Vlad Buslov <vladbu@nvidia.com> --- v2: fix a description error net/sched/cls_api.c | 1 + 1 file changed, 1 insertion(+)