| Message ID | 20220921140524.3831101-15-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 24d64ced1bf8d333dc4697d1cc6d2b4f64cc145d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: remove unnecessary set_drvdata() | expand |
On Wed, Sep 21, 2022 at 10:05:20PM +0800, Yang Yingliang wrote: > Remove unnecessary set_drvdata(NULL) function in ->remove(), > the driver_data will be set to NULL in device_unbind_cleanup() > after calling ->remove(). > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/dsa/realtek/realtek-mdio.c | 2 -- > drivers/net/dsa/realtek/realtek-smi.c | 2 -- > 2 files changed, 4 deletions(-) Acked-by: Alvin Šipraga <alsi@bang-olufsen.dk> > > diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c > index c58f49d558d2..3e54fac5f902 100644 > --- a/drivers/net/dsa/realtek/realtek-mdio.c > +++ b/drivers/net/dsa/realtek/realtek-mdio.c > @@ -245,8 +245,6 @@ static void realtek_mdio_remove(struct mdio_device *mdiodev) > /* leave the device reset asserted */ > if (priv->reset) > gpiod_set_value(priv->reset, 1); > - > - dev_set_drvdata(&mdiodev->dev, NULL); > } > > static void realtek_mdio_shutdown(struct mdio_device *mdiodev) > diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c > index 45992f79ec8d..1b447d96b9c4 100644 > --- a/drivers/net/dsa/realtek/realtek-smi.c > +++ b/drivers/net/dsa/realtek/realtek-smi.c > @@ -522,8 +522,6 @@ static int realtek_smi_remove(struct platform_device *pdev) > if (priv->reset) > gpiod_set_value(priv->reset, 1); > > - platform_set_drvdata(pdev, NULL); > - > return 0; > } > > -- > 2.25.1 >
On Wed, Sep 21, 2022 at 3:58 PM Yang Yingliang <yangyingliang@huawei.com> wrote: > Remove unnecessary set_drvdata(NULL) function in ->remove(), > the driver_data will be set to NULL in device_unbind_cleanup() > after calling ->remove(). > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c index c58f49d558d2..3e54fac5f902 100644 --- a/drivers/net/dsa/realtek/realtek-mdio.c +++ b/drivers/net/dsa/realtek/realtek-mdio.c @@ -245,8 +245,6 @@ static void realtek_mdio_remove(struct mdio_device *mdiodev) /* leave the device reset asserted */ if (priv->reset) gpiod_set_value(priv->reset, 1); - - dev_set_drvdata(&mdiodev->dev, NULL); } static void realtek_mdio_shutdown(struct mdio_device *mdiodev) diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c index 45992f79ec8d..1b447d96b9c4 100644 --- a/drivers/net/dsa/realtek/realtek-smi.c +++ b/drivers/net/dsa/realtek/realtek-smi.c @@ -522,8 +522,6 @@ static int realtek_smi_remove(struct platform_device *pdev) if (priv->reset) gpiod_set_value(priv->reset, 1); - platform_set_drvdata(pdev, NULL); - return 0; }
Remove unnecessary set_drvdata(NULL) function in ->remove(), the driver_data will be set to NULL in device_unbind_cleanup() after calling ->remove(). Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/dsa/realtek/realtek-mdio.c | 2 -- drivers/net/dsa/realtek/realtek-smi.c | 2 -- 2 files changed, 4 deletions(-)