| Message ID | 20220923093509.521560-1-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | BPF |
| Headers | show |
| Series | bpf: Remove obsolete iterators_bpf__open_and_load() | expand |
On Fri, Sep 23, 2022 at 2:35 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > Commit cb80ddc67152 ("bpf: Convert bpf_preload.ko to use light > skeleton.") drops the last caller of generic_free_nodedata(), > it is useless, so remove it. > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > kernel/bpf/preload/iterators/iterators.lskel.h | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/kernel/bpf/preload/iterators/iterators.lskel.h b/kernel/bpf/preload/iterators/iterators.lskel.h > index 70f236a82fe1..e5f9c608f7f7 100644 > --- a/kernel/bpf/preload/iterators/iterators.lskel.h > +++ b/kernel/bpf/preload/iterators/iterators.lskel.h > @@ -407,19 +407,4 @@ iterators_bpf__load(struct iterators_bpf *skel) > return 0; > } > > -static inline struct iterators_bpf * > -iterators_bpf__open_and_load(void) > -{ > - struct iterators_bpf *skel; > - > - skel = iterators_bpf__open(); > - if (!skel) > - return NULL; > - if (iterators_bpf__load(skel)) { > - iterators_bpf__destroy(skel); > - return NULL; > - } > - return skel; > -} > - Top of this file says: /* THIS FILE IS AUTOGENERATED! */ Please do NOT send such patches for it.
> Top of this file says: > /* THIS FILE IS AUTOGENERATED! */ > > Please do NOT send such patches for it. It's my negligence，thanks for taking the time to review this patch! On 2022/9/23 22:31, Alexei Starovoitov wrote: > On Fri, Sep 23, 2022 at 2:35 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: >> Commit cb80ddc67152 ("bpf: Convert bpf_preload.ko to use light >> skeleton.") drops the last caller of generic_free_nodedata(), >> it is useless, so remove it. >> >> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> >> --- >> kernel/bpf/preload/iterators/iterators.lskel.h | 15 --------------- >> 1 file changed, 15 deletions(-) >> >> diff --git a/kernel/bpf/preload/iterators/iterators.lskel.h b/kernel/bpf/preload/iterators/iterators.lskel.h >> index 70f236a82fe1..e5f9c608f7f7 100644 >> --- a/kernel/bpf/preload/iterators/iterators.lskel.h >> +++ b/kernel/bpf/preload/iterators/iterators.lskel.h >> @@ -407,19 +407,4 @@ iterators_bpf__load(struct iterators_bpf *skel) >> return 0; >> } >> >> -static inline struct iterators_bpf * >> -iterators_bpf__open_and_load(void) >> -{ >> - struct iterators_bpf *skel; >> - >> - skel = iterators_bpf__open(); >> - if (!skel) >> - return NULL; >> - if (iterators_bpf__load(skel)) { >> - iterators_bpf__destroy(skel); >> - return NULL; >> - } >> - return skel; >> -} >> - > Top of this file says: > /* THIS FILE IS AUTOGENERATED! */ > > Please do NOT send such patches for it. > .
diff --git a/kernel/bpf/preload/iterators/iterators.lskel.h b/kernel/bpf/preload/iterators/iterators.lskel.h index 70f236a82fe1..e5f9c608f7f7 100644 --- a/kernel/bpf/preload/iterators/iterators.lskel.h +++ b/kernel/bpf/preload/iterators/iterators.lskel.h @@ -407,19 +407,4 @@ iterators_bpf__load(struct iterators_bpf *skel) return 0; } -static inline struct iterators_bpf * -iterators_bpf__open_and_load(void) -{ - struct iterators_bpf *skel; - - skel = iterators_bpf__open(); - if (!skel) - return NULL; - if (iterators_bpf__load(skel)) { - iterators_bpf__destroy(skel); - return NULL; - } - return skel; -} - #endif /* __ITERATORS_BPF_SKEL_H__ */
Commit cb80ddc67152 ("bpf: Convert bpf_preload.ko to use light skeleton.") drops the last caller of generic_free_nodedata(), it is useless, so remove it. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- kernel/bpf/preload/iterators/iterators.lskel.h | 15 --------------- 1 file changed, 15 deletions(-)