| Message ID | 20220923202911.119729-3-gerhard@engleder-embedded.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | tsnep: multi queue support and some other improvements | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 47 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 23/09/2022 22:29, Gerhard Engleder wrote: > Additional TX/RX queue pairs require dedicated interrupts. Extend > binding with additional interrupts. > > Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> > --- > .../bindings/net/engleder,tsnep.yaml | 37 ++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml > index 37e08ee744a8..ce1f1bd413c2 100644 > --- a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml > +++ b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml > @@ -20,7 +20,23 @@ properties: > maxItems: 1 > > interrupts: > - maxItems: 1 > + minItems: 1 > + maxItems: 8 > + > + interrupt-names: > + minItems: 1 > + maxItems: 8 > + items: > + pattern: '^mac|txrx-[1-7]$' No. The order of items must be fixed. Now you allow any combination, which is exactly what we do not want. > + description: > + If more than one interrupt is available, then interrupts are > + identified by their names. Not really. Interrupts are fixed, unless explicitly mentioned otherwise. > + "mac" is the main interrupt for basic MAC features and the first > + TX/RX queue pair. If only a single interrupt is available, then > + it is assumed that this interrupt is the "mac" interrupt. > + "txrx-[1-7]" are the interrupts for additional TX/RX queue pairs. > + These interrupt names shall start with index 1 and increment the > + index by 1 with every further TX/RX queue pair. Skip last three sentences - they will become redundant after implementing proper items. > > dma-coherent: true > > @@ -78,4 +94,23 @@ examples: > }; > }; > }; Missing line break. Best regards, Krzysztof
On 24.09.22 11:17, Krzysztof Kozlowski wrote: > On 23/09/2022 22:29, Gerhard Engleder wrote: >> Additional TX/RX queue pairs require dedicated interrupts. Extend >> binding with additional interrupts. >> >> Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> >> --- >> .../bindings/net/engleder,tsnep.yaml | 37 ++++++++++++++++++- >> 1 file changed, 36 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml >> index 37e08ee744a8..ce1f1bd413c2 100644 >> --- a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml >> +++ b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml >> @@ -20,7 +20,23 @@ properties: >> maxItems: 1 >> >> interrupts: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 8 >> + >> + interrupt-names: >> + minItems: 1 >> + maxItems: 8 >> + items: >> + pattern: '^mac|txrx-[1-7]$' > > No. The order of items must be fixed. Now you allow any combination, > which is exactly what we do not want. Ok. I will do it like in https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/net/microchip,sparx5-switch.yaml#L58 >> + description: >> + If more than one interrupt is available, then interrupts are >> + identified by their names. > > Not really. Interrupts are fixed, unless explicitly mentioned otherwise. > >> + "mac" is the main interrupt for basic MAC features and the first >> + TX/RX queue pair. If only a single interrupt is available, then >> + it is assumed that this interrupt is the "mac" interrupt. >> + "txrx-[1-7]" are the interrupts for additional TX/RX queue pairs. >> + These interrupt names shall start with index 1 and increment the >> + index by 1 with every further TX/RX queue pair. > > Skip last three sentences - they will become redundant after > implementing proper items. I will rework description for fixed order. >> >> dma-coherent: true >> >> @@ -78,4 +94,23 @@ examples: >> }; >> }; >> }; > > Missing line break. I will add it. > Best regards, > Krzysztof Thanks! Gerhard
diff --git a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml index 37e08ee744a8..ce1f1bd413c2 100644 --- a/Documentation/devicetree/bindings/net/engleder,tsnep.yaml +++ b/Documentation/devicetree/bindings/net/engleder,tsnep.yaml @@ -20,7 +20,23 @@ properties: maxItems: 1 interrupts: - maxItems: 1 + minItems: 1 + maxItems: 8 + + interrupt-names: + minItems: 1 + maxItems: 8 + items: + pattern: '^mac|txrx-[1-7]$' + description: + If more than one interrupt is available, then interrupts are + identified by their names. + "mac" is the main interrupt for basic MAC features and the first + TX/RX queue pair. If only a single interrupt is available, then + it is assumed that this interrupt is the "mac" interrupt. + "txrx-[1-7]" are the interrupts for additional TX/RX queue pairs. + These interrupt names shall start with index 1 and increment the + index by 1 with every further TX/RX queue pair. dma-coherent: true @@ -78,4 +94,23 @@ examples: }; }; }; + tnsep1: ethernet@a0010000 { + compatible = "engleder,tsnep"; + reg = <0x0 0xa0010000 0x0 0x10000>; + interrupts = <0 93 1>, <0 94 1>, <0 95 1>, <0 96 1>; + interrupt-names = "mac", "txrx-1", "txrx-2", "txrx-3"; + interrupt-parent = <&gic>; + local-mac-address = [00 00 00 00 00 00]; + phy-mode = "rgmii"; + phy-handle = <&phy1>; + mdio { + #address-cells = <1>; + #size-cells = <0>; + suppress-preamble; + phy1: ethernet-phy@1 { + reg = <1>; + rxc-skew-ps = <1080>; + }; + }; + }; };
Additional TX/RX queue pairs require dedicated interrupts. Extend binding with additional interrupts. Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com> --- .../bindings/net/engleder,tsnep.yaml | 37 ++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-)