| Message ID | 20220926150740.6684-2-linux@fw-web.de (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add Support for Dell 5811e with usb-id 0x413c:0x81c2 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessed tree name to be net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 3 of 3 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 7 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Mon, Sep 26, 2022 at 05:07:39PM +0200, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add support for Dell 5811e (EM7455) with USB-id 0x413c:0x81c2. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > Cc: stable@vger.kernel.org > --- > drivers/usb/serial/qcserial.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c > index 586ef5551e76..7897609916a6 100644 > --- a/drivers/usb/serial/qcserial.c > +++ b/drivers/usb/serial/qcserial.c > @@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = { > {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */ > {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */ > {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */ > + {DEVICE_SWI(0x413c, 0x81c2)}, /* Dell Wireless 5811e QDL */ I assume this is not just for QDL mode as the comment indicates. Could you post the output of usb-devices for this device? > {DEVICE_SWI(0x413c, 0x81cb)}, /* Dell Wireless 5816e QDL */ > {DEVICE_SWI(0x413c, 0x81cc)}, /* Dell Wireless 5816e */ > {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */ Johan
Hi > Gesendet: Dienstag, 27. September 2022 um 08:31 Uhr > Von: "Johan Hovold" <johan@kernel.org> > An: "Frank Wunderlich" <linux@fw-web.de> > Cc: linux-usb@vger.kernel.org, "Frank Wunderlich" <frank-w@public-files.de>, "Bjørn Mork" <bjorn@mork.no>, "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org > Betreff: Re: [PATCH 1/2] USB: serial: qcserial: add new usb-id for Dell branded EM7455 > > On Mon, Sep 26, 2022 at 05:07:39PM +0200, Frank Wunderlich wrote: > > From: Frank Wunderlich <frank-w@public-files.de> > > +++ b/drivers/usb/serial/qcserial.c > > @@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = { > > {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */ > > {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */ > > {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */ > > + {DEVICE_SWI(0x413c, 0x81c2)}, /* Dell Wireless 5811e QDL */ > > I assume this is not just for QDL mode as the comment indicates. to be honest, have not found out yet what QDL means and assumed that it's like the other dw5811e, so not changed comment :) > Could you post the output of usb-devices for this device? Bus 001 Device 004: ID 413c:81c2 Sierra Wireless, Incorporated DW5811e Snapdragon™ X7 LTE /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci-mtk/2p, 480M ID 1d6b:0002 Linux Foundation 2.0 root hub |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M ID 1a40:0101 Terminus Technology Inc. Hub |__ Port 1: Dev 6, If 0, Class=Vendor Specific Class, Driver=qcserial, 480M ID 413c:81c2 Dell Computer Corp. |__ Port 1: Dev 6, If 2, Class=Vendor Specific Class, Driver=qcserial, 480M ID 413c:81c2 Dell Computer Corp. |__ Port 1: Dev 6, If 3, Class=Vendor Specific Class, Driver=qcserial, 480M ID 413c:81c2 Dell Computer Corp. |__ Port 1: Dev 6, If 8, Class=Vendor Specific Class, Driver=qmi_wwan, 480M ID 413c:81c2 Dell Computer Corp. > > {DEVICE_SWI(0x413c, 0x81cb)}, /* Dell Wireless 5816e QDL */ > > {DEVICE_SWI(0x413c, 0x81cc)}, /* Dell Wireless 5816e */ > > {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */ > > Johan regards Frank
On Tue, Sep 27, 2022 at 08:48:23AM +0200, Frank Wunderlich wrote: > Hi > > > Gesendet: Dienstag, 27. September 2022 um 08:31 Uhr > > Von: "Johan Hovold" <johan@kernel.org> > > On Mon, Sep 26, 2022 at 05:07:39PM +0200, Frank Wunderlich wrote: > > > From: Frank Wunderlich <frank-w@public-files.de> > > > > +++ b/drivers/usb/serial/qcserial.c > > > @@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = { > > > {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */ > > > {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */ > > > {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */ > > > + {DEVICE_SWI(0x413c, 0x81c2)}, /* Dell Wireless 5811e QDL */ > > > > I assume this is not just for QDL mode as the comment indicates. > > to be honest, have not found out yet what QDL means and assumed that > it's like the other dw5811e, so not changed comment :) I believe that's Qualcomm Download mode or similar, for flashing the device (cf. 5816e which has two entries, one for QDL mode). > > Could you post the output of usb-devices for this device? > > Bus 001 Device 004: ID 413c:81c2 Sierra Wireless, Incorporated DW5811e Snapdragon™ X7 LTE > > > /: Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci-mtk/2p, 480M > ID 1d6b:0002 Linux Foundation 2.0 root hub > |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/4p, 480M > ID 1a40:0101 Terminus Technology Inc. Hub > |__ Port 1: Dev 6, If 0, Class=Vendor Specific Class, Driver=qcserial, 480M > ID 413c:81c2 Dell Computer Corp. > |__ Port 1: Dev 6, If 2, Class=Vendor Specific Class, Driver=qcserial, 480M > ID 413c:81c2 Dell Computer Corp. > |__ Port 1: Dev 6, If 3, Class=Vendor Specific Class, Driver=qcserial, 480M > ID 413c:81c2 Dell Computer Corp. > |__ Port 1: Dev 6, If 8, Class=Vendor Specific Class, Driver=qmi_wwan, 480M > ID 413c:81c2 Dell Computer Corp. Thanks. The above doesn't include all the details that usb-devices (or lsusb -v) would but still confirms the basic bits so I've applied the patch now after amending the comment. Johan
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index 586ef5551e76..7897609916a6 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c @@ -177,6 +177,7 @@ static const struct usb_device_id id_table[] = { {DEVICE_SWI(0x413c, 0x81b3)}, /* Dell Wireless 5809e Gobi(TM) 4G LTE Mobile Broadband Card (rev3) */ {DEVICE_SWI(0x413c, 0x81b5)}, /* Dell Wireless 5811e QDL */ {DEVICE_SWI(0x413c, 0x81b6)}, /* Dell Wireless 5811e QDL */ + {DEVICE_SWI(0x413c, 0x81c2)}, /* Dell Wireless 5811e QDL */ {DEVICE_SWI(0x413c, 0x81cb)}, /* Dell Wireless 5816e QDL */ {DEVICE_SWI(0x413c, 0x81cc)}, /* Dell Wireless 5816e */ {DEVICE_SWI(0x413c, 0x81cf)}, /* Dell Wireless 5819 */