From patchwork Mon Sep 26 23:18:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Rosenberg X-Patchwork-Id: 12989538 X-Patchwork-Delegate: bpf@iogearbox.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F374CC07E9D for ; Mon, 26 Sep 2022 23:20:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbiIZXUS (ORCPT ); Mon, 26 Sep 2022 19:20:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231218AbiIZXTI (ORCPT ); Mon, 26 Sep 2022 19:19:08 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 084A8DC12F for ; Mon, 26 Sep 2022 16:18:59 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id f3-20020a056902038300b00696588a0e87so7065579ybs.3 for ; Mon, 26 Sep 2022 16:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date; bh=XIhmt29MnSHMOUbW5hWxk0PJQl3NxeeWjpzsriw+TZI=; b=o66d+GY2M6xQDpW8c+jjW5mRmO2/zo5TbEA83P3bE8MkORJDWa6zNbP1M+88MIdFNa zO3jdsiPWGt9de4+zcGtH7/P8z0vlOUcLdYgsvT3Oj7xbUuHnJhCp/95cyZ8/vl/6S6t HXl2chUbbyB9efN67IfnwzUSoJ+vnVuEtK9j/9sWbt89KM6Q14wcBacRrYlANMd+hJUj whypPugP0O0WEMAcDkhpy+2ZbiKV2tsMIPGhDOB5S3fdEbhb7aLl3OOCsPBqWamXYi4E mfICZEsdaG/ZMqdp1/oaclJqi+c7zldrdO/pPatkIq7IaQSM2f4hQAHKUKgzmMxwKePf M1OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date; bh=XIhmt29MnSHMOUbW5hWxk0PJQl3NxeeWjpzsriw+TZI=; b=Rhnr7npu6a3i8TVvBmpHILIH+W6GTjKtZzcnhHprTeGDDZR1EevTQlJouLhhP96lkL QfPps34CF+58lU5R4GDYhzKm7GXqzv05MFRf4I32Z/c/FrYEZyMOMZ/CrBXOIXTYIiwh weM39IDuO+WRV/qw7VyxuBVPSG2/eQblgXv5QiGUVJqXSeFaK69HEO5nKa2Yn5Z98ajX wQwFOf+M96fszazWIqd57H6rOW1lDlorQqmweY9ttp4ZgHAS2gcFK/OKUl5+BHi2y0aa HeoskwYwDvktOCM75hQTxuBMjy26cqjWsdC+uhpkx1m3IBkRFXos97LDGYr6edeGxjd+ JrZQ== X-Gm-Message-State: ACrzQf1xBsMFEIcEO/tr9iugnBJwbLdfRo+hr9BkT8OzQN2LEsWc7dfi bHemhGzPwqL149+anDnWLU45yPAbFrg= X-Google-Smtp-Source: AMsMyM72yYQI5nrA0MNBYDI6J1jX3hc41LxhbrmvGHzt69qbX3A9FfCw8w+KvIQtn1Hc99RXohw4XKiWJZ0= X-Received: from drosen.mtv.corp.google.com ([2620:15c:211:200:4643:a68e:2b7:f873]) (user=drosen job=sendgmr) by 2002:a25:bb8d:0:b0:696:340c:a672 with SMTP id y13-20020a25bb8d000000b00696340ca672mr24097705ybg.332.1664234338780; Mon, 26 Sep 2022 16:18:58 -0700 (PDT) Date: Mon, 26 Sep 2022 16:18:07 -0700 In-Reply-To: <20220926231822.994383-1-drosen@google.com> Mime-Version: 1.0 References: <20220926231822.994383-1-drosen@google.com> X-Mailer: git-send-email 2.37.3.998.g577e59143f-goog Message-ID: <20220926231822.994383-12-drosen@google.com> Subject: [PATCH 11/26] fuse-bpf: Add lseek support From: Daniel Rosenberg To: Miklos Szeredi , Alexei Starovoitov , Daniel Borkmann , John Fastabend Cc: Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Daniel Rosenberg , Paul Lawrence , Alessio Balsini , David Anderson , Sandeep Patil , linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, kernel-team@android.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Signed-off-by: Daniel Rosenberg Signed-off-by: Paul Lawrence --- fs/fuse/backing.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++ fs/fuse/file.c | 8 +++++ fs/fuse/fuse_i.h | 15 +++++++++- 3 files changed, 96 insertions(+), 1 deletion(-) diff --git a/fs/fuse/backing.c b/fs/fuse/backing.c index fa8805e24061..97e92c633cfd 100644 --- a/fs/fuse/backing.c +++ b/fs/fuse/backing.c @@ -77,6 +77,80 @@ int parse_fuse_entry_bpf(struct fuse_entry_bpf *feb) return err; } +int fuse_lseek_initialize_in(struct bpf_fuse_args *fa, struct fuse_lseek_io *flio, + struct file *file, loff_t offset, int whence) +{ + struct fuse_file *fuse_file = file->private_data; + + flio->fli = (struct fuse_lseek_in) { + .fh = fuse_file->fh, + .offset = offset, + .whence = whence, + }; + + *fa = (struct bpf_fuse_args) { + .nodeid = get_node_id(file->f_inode), + .opcode = FUSE_LSEEK, + .in_numargs = 1, + .in_args[0].size = sizeof(flio->fli), + .in_args[0].value = &flio->fli, + }; + + return 0; +} + +int fuse_lseek_initialize_out(struct bpf_fuse_args *fa, struct fuse_lseek_io *flio, + struct file *file, loff_t offset, int whence) +{ + fa->out_numargs = 1; + fa->out_args[0].size = sizeof(flio->flo); + fa->out_args[0].value = &flio->flo; + + return 0; +} + +int fuse_lseek_backing(struct bpf_fuse_args *fa, loff_t *out, + struct file *file, loff_t offset, int whence) +{ + const struct fuse_lseek_in *fli = fa->in_args[0].value; + struct fuse_lseek_out *flo = fa->out_args[0].value; + struct fuse_file *fuse_file = file->private_data; + struct file *backing_file = fuse_file->backing_file; + + /* TODO: Handle changing of the file handle */ + if (offset == 0) { + if (whence == SEEK_CUR) { + flo->offset = file->f_pos; + *out = flo->offset; + return 0; + } + + if (whence == SEEK_SET) { + flo->offset = vfs_setpos(file, 0, 0); + *out = flo->offset; + return 0; + } + } + + inode_lock(file->f_inode); + backing_file->f_pos = file->f_pos; + *out = vfs_llseek(backing_file, fli->offset, fli->whence); + flo->offset = *out; + inode_unlock(file->f_inode); + return 0; +} + +int fuse_lseek_finalize(struct bpf_fuse_args *fa, loff_t *out, + struct file *file, loff_t offset, int whence) +{ + struct fuse_lseek_out *flo = fa->out_args[0].value; + + if (!fa->error_in) + file->f_pos = flo->offset; + *out = flo->offset; + return 0; +} + ssize_t fuse_backing_mmap(struct file *file, struct vm_area_struct *vma) { int ret; diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 138890eae07c..dd4485261cc7 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -2703,6 +2703,14 @@ static loff_t fuse_file_llseek(struct file *file, loff_t offset, int whence) { loff_t retval; struct inode *inode = file_inode(file); +#ifdef CONFIG_FUSE_BPF + if (fuse_bpf_backing(inode, struct fuse_lseek_io, retval, + fuse_lseek_initialize_in, fuse_lseek_initialize_out, + fuse_lseek_backing, + fuse_lseek_finalize, + file, offset, whence)) + return retval; +#endif switch (whence) { case SEEK_SET: diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index a9653f71c145..fc3e8adf0422 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h @@ -1404,9 +1404,22 @@ struct fuse_entry_bpf { struct bpf_prog *bpf; }; - int parse_fuse_entry_bpf(struct fuse_entry_bpf *feb); +struct fuse_lseek_io { + struct fuse_lseek_in fli; + struct fuse_lseek_out flo; +}; + +int fuse_lseek_initialize_in(struct bpf_fuse_args *fa, struct fuse_lseek_io *fli, + struct file *file, loff_t offset, int whence); +int fuse_lseek_initialize_out(struct bpf_fuse_args *fa, struct fuse_lseek_io *fli, + struct file *file, loff_t offset, int whence); +int fuse_lseek_backing(struct bpf_fuse_args *fa, loff_t *out, struct file *file, + loff_t offset, int whence); +int fuse_lseek_finalize(struct bpf_fuse_args *fa, loff_t *out, struct file *file, + loff_t offset, int whence); + ssize_t fuse_backing_mmap(struct file *file, struct vm_area_struct *vma); struct fuse_lookup_io {