| Message ID | 20220927024511.14665-1-shangxiaojing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6db239f01abc7e04a9bc2a0c59c1db1c1ebf9eb3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [-next] wwan_hwsim: Use skb_put_data() instead of skb_put/memcpy pair | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Paolo Abeni <pabeni@redhat.com>: On Tue, 27 Sep 2022 10:45:11 +0800 you wrote: > Use skb_put_data() instead of skb_put() and memcpy(), which is clear. > > Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> > --- > drivers/net/wwan/wwan_hwsim.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Here is the summary with links: - [-next] wwan_hwsim: Use skb_put_data() instead of skb_put/memcpy pair https://git.kernel.org/netdev/net-next/c/6db239f01abc You are awesome, thank you!
diff --git a/drivers/net/wwan/wwan_hwsim.c b/drivers/net/wwan/wwan_hwsim.c index fad642f9ffd8..ff09a8cedf93 100644 --- a/drivers/net/wwan/wwan_hwsim.c +++ b/drivers/net/wwan/wwan_hwsim.c @@ -157,8 +157,8 @@ static int wwan_hwsim_port_tx(struct wwan_port *wport, struct sk_buff *in) if ((i + 1) < in->len && in->data[i + 1] == '\n') i++; n = i - s + 1; - memcpy(skb_put(out, n), &in->data[s], n);/* Echo */ - memcpy(skb_put(out, 6), "\r\nOK\r\n", 6); + skb_put_data(out, &in->data[s], n);/* Echo */ + skb_put_data(out, "\r\nOK\r\n", 6); s = i + 1; port->pstate = AT_PARSER_WAIT_A; } else if (port->pstate == AT_PARSER_SKIP_LINE) { @@ -171,7 +171,7 @@ static int wwan_hwsim_port_tx(struct wwan_port *wport, struct sk_buff *in) if (i > s) { /* Echo the processed portion of a not yet completed command */ n = i - s; - memcpy(skb_put(out, n), &in->data[s], n); + skb_put_data(out, &in->data[s], n); } consume_skb(in);
Use skb_put_data() instead of skb_put() and memcpy(), which is clear. Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com> --- drivers/net/wwan/wwan_hwsim.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)