| Message ID | 20220928004157.279731-1-seanga2@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d4ddeefa64ab36d211ff57a64d263c158e017581 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: sunhme: Fix undersized zeroing of quattro->happy_meals | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Tue, 27 Sep 2022 20:41:57 -0400 you wrote: > Just use kzalloc instead. > > Fixes: d6f1e89bdbb8 ("sunhme: Return an ERR_PTR from quattro_pci_find") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Sean Anderson <seanga2@gmail.com> > --- > > [...] Here is the summary with links: - [net-next] net: sunhme: Fix undersized zeroing of quattro->happy_meals https://git.kernel.org/netdev/net-next/c/d4ddeefa64ab You are awesome, thank you!
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c index 3afa73db500c..62deed210a95 100644 --- a/drivers/net/ethernet/sun/sunhme.c +++ b/drivers/net/ethernet/sun/sunhme.c @@ -2409,12 +2409,10 @@ static struct quattro *quattro_sbus_find(struct platform_device *child) if (qp) return qp; - qp = kmalloc(sizeof(struct quattro), GFP_KERNEL); + qp = kzalloc(sizeof(*qp), GFP_KERNEL); if (!qp) return NULL; - memset(qp->happy_meals, 0, sizeof(*qp->happy_meals)); - qp->quattro_dev = child; qp->next = qfe_sbus_list; qfe_sbus_list = qp;
Just use kzalloc instead. Fixes: d6f1e89bdbb8 ("sunhme: Return an ERR_PTR from quattro_pci_find") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Sean Anderson <seanga2@gmail.com> --- drivers/net/ethernet/sun/sunhme.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)