| Message ID | 20220930175725.2548233-1-zyytlz.wz@163.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 12aece8b01507a2d357a1861f470e83621fbb6f2 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | eth: sp7021: fix use after free bug in spl2sw_nvmem_get_mac_address | expand |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Sat, 1 Oct 2022 01:57:25 +0800 you wrote: > This frees "mac" and tries to display its address as part of the error > message on the next line. Swap the order. > > Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021") > Signed-off-by: Zheng Wang <zyytlz.wz@163.com> > --- > drivers/net/ethernet/sunplus/spl2sw_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - eth: sp7021: fix use after free bug in spl2sw_nvmem_get_mac_address https://git.kernel.org/netdev/net/c/12aece8b0150 You are awesome, thank you!
diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c index 546206640492..61d1d07dc070 100644 --- a/drivers/net/ethernet/sunplus/spl2sw_driver.c +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c @@ -248,8 +248,8 @@ static int spl2sw_nvmem_get_mac_address(struct device *dev, struct device_node * /* Check if mac address is valid */ if (!is_valid_ether_addr(mac)) { - kfree(mac); dev_info(dev, "Invalid mac address in nvmem (%pM)!\n", mac); + kfree(mac); return -EINVAL; }
This frees "mac" and tries to display its address as part of the error message on the next line. Swap the order. Fixes: fd3040b9394c ("net: ethernet: Add driver for Sunplus SP7021") Signed-off-by: Zheng Wang <zyytlz.wz@163.com> --- drivers/net/ethernet/sunplus/spl2sw_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)