| Message ID | 20221014205104.2822159-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: Remove "status" from schema examples, again | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 14/10/2022 16:51, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > A meta-schema check for this is pending, so hopefully the last time to > fix these. > > Fix the indentation in intel,phy-thunderbay-emmc while we're here. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 14 Oct 2022 15:51:04 -0500 Rob Herring <robh@kernel.org> wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > A meta-schema check for this is pending, so hopefully the last time to > fix these. > > Fix the indentation in intel,phy-thunderbay-emmc while we're here. > > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> #for-iio > --- > .../arm/tegra/nvidia,tegra-ccplex-cluster.yaml | 1 - > .../display/tegra/nvidia,tegra124-dpaux.yaml | 1 - > .../display/tegra/nvidia,tegra186-display.yaml | 2 -- > .../bindings/iio/addac/adi,ad74413r.yaml | 1 - > .../devicetree/bindings/net/cdns,macb.yaml | 1 - > .../devicetree/bindings/net/nxp,dwmac-imx.yaml | 1 - > .../bindings/phy/intel,phy-thunderbay-emmc.yaml | 15 +++++++-------- > 7 files changed, 7 insertions(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml > index 711bb4d08c60..869c266e7ebc 100644 > --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml > +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml > @@ -47,5 +47,4 @@ examples: > compatible = "nvidia,tegra234-ccplex-cluster"; > reg = <0x0e000000 0x5ffff>; > nvidia,bpmp = <&bpmp>; > - status = "okay"; > }; > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml > index 9ab123cd2325..5cdbc527a560 100644 > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml > @@ -128,7 +128,6 @@ examples: > resets = <&tegra_car 181>; > reset-names = "dpaux"; > power-domains = <&pd_sor>; > - status = "disabled"; > > state_dpaux_aux: pinmux-aux { > groups = "dpaux-io"; > diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml > index 8c0231345529..ce5c673f940c 100644 > --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml > +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml > @@ -138,7 +138,6 @@ examples: > <&bpmp TEGRA186_CLK_NVDISPLAY_DSC>, > <&bpmp TEGRA186_CLK_NVDISPLAYHUB>; > clock-names = "disp", "dsc", "hub"; > - status = "disabled"; > > power-domains = <&bpmp TEGRA186_POWER_DOMAIN_DISP>; > > @@ -227,7 +226,6 @@ examples: > clocks = <&bpmp TEGRA194_CLK_NVDISPLAY_DISP>, > <&bpmp TEGRA194_CLK_NVDISPLAYHUB>; > clock-names = "disp", "hub"; > - status = "disabled"; > > power-domains = <&bpmp TEGRA194_POWER_DOMAIN_DISP>; > > diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml > index 03bb90a7f4f8..d2a9f92c0a6d 100644 > --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml > +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml > @@ -114,7 +114,6 @@ examples: > #size-cells = <0>; > > cs-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; > - status = "okay"; > > ad74413r@0 { > compatible = "adi,ad74413r"; > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml > index 318f4efe7f6f..bef5e0f895be 100644 > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > @@ -203,7 +203,6 @@ examples: > power-domains = <&zynqmp_firmware PD_ETH_1>; > resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>; > reset-names = "gem1_rst"; > - status = "okay"; > phy-mode = "sgmii"; > phys = <&psgtr 1 PHY_TYPE_SGMII 1 1>; > fixed-link { > diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml > index 4c155441acbf..0270b0ca166b 100644 > --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml > +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml > @@ -92,5 +92,4 @@ examples: > <&clk IMX8MP_CLK_ENET_QOS>; > clock-names = "stmmaceth", "pclk", "ptp_ref", "tx"; > phy-mode = "rgmii"; > - status = "disabled"; > }; > diff --git a/Documentation/devicetree/bindings/phy/intel,phy-thunderbay-emmc.yaml b/Documentation/devicetree/bindings/phy/intel,phy-thunderbay-emmc.yaml > index 34bdb5c4cae8..b09e5ba5e127 100644 > --- a/Documentation/devicetree/bindings/phy/intel,phy-thunderbay-emmc.yaml > +++ b/Documentation/devicetree/bindings/phy/intel,phy-thunderbay-emmc.yaml > @@ -36,11 +36,10 @@ additionalProperties: false > > examples: > - | > - mmc_phy@80440800 { > - #phy-cells = <0x0>; > - compatible = "intel,thunderbay-emmc-phy"; > - status = "okay"; > - reg = <0x80440800 0x100>; > - clocks = <&emmc>; > - clock-names = "emmcclk"; > - }; > + mmc_phy@80440800 { > + #phy-cells = <0x0>; > + compatible = "intel,thunderbay-emmc-phy"; > + reg = <0x80440800 0x100>; > + clocks = <&emmc>; > + clock-names = "emmcclk"; > + };
On 14-10-22, 15:51, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > A meta-schema check for this is pending, so hopefully the last time to > fix these. > > Fix the indentation in intel,phy-thunderbay-emmc while we're here. Acked-By: Vinod Koul <vkoul@kernel.org>
On 14/10/2022 at 22:51, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > A meta-schema check for this is pending, so hopefully the last time to > fix these. > > Fix the indentation in intel,phy-thunderbay-emmc while we're here. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../arm/tegra/nvidia,tegra-ccplex-cluster.yaml | 1 - > .../display/tegra/nvidia,tegra124-dpaux.yaml | 1 - > .../display/tegra/nvidia,tegra186-display.yaml | 2 -- > .../bindings/iio/addac/adi,ad74413r.yaml | 1 - > .../devicetree/bindings/net/cdns,macb.yaml | 1 - > .../devicetree/bindings/net/nxp,dwmac-imx.yaml | 1 - > .../bindings/phy/intel,phy-thunderbay-emmc.yaml | 15 +++++++-------- > 7 files changed, 7 insertions(+), 15 deletions(-) [..] > diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml > index 318f4efe7f6f..bef5e0f895be 100644 > --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml > +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml > @@ -203,7 +203,6 @@ examples: > power-domains = <&zynqmp_firmware PD_ETH_1>; > resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>; > reset-names = "gem1_rst"; > - status = "okay"; > phy-mode = "sgmii"; > phys = <&psgtr 1 PHY_TYPE_SGMII 1 1>; > fixed-link { Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> Thanks Rob. Best regards, Nicolas
On Fri, Oct 14, 2022 at 03:51:04PM -0500, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > A meta-schema check for this is pending, so hopefully the last time to > fix these. > > Fix the indentation in intel,phy-thunderbay-emmc while we're here. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../arm/tegra/nvidia,tegra-ccplex-cluster.yaml | 1 - > .../display/tegra/nvidia,tegra124-dpaux.yaml | 1 - > .../display/tegra/nvidia,tegra186-display.yaml | 2 -- > .../bindings/iio/addac/adi,ad74413r.yaml | 1 - > .../devicetree/bindings/net/cdns,macb.yaml | 1 - > .../devicetree/bindings/net/nxp,dwmac-imx.yaml | 1 - > .../bindings/phy/intel,phy-thunderbay-emmc.yaml | 15 +++++++-------- > 7 files changed, 7 insertions(+), 15 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On Fri, 14 Oct 2022 15:51:04 -0500, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > A meta-schema check for this is pending, so hopefully the last time to > fix these. > > Fix the indentation in intel,phy-thunderbay-emmc while we're here. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../arm/tegra/nvidia,tegra-ccplex-cluster.yaml | 1 - > .../display/tegra/nvidia,tegra124-dpaux.yaml | 1 - > .../display/tegra/nvidia,tegra186-display.yaml | 2 -- > .../bindings/iio/addac/adi,ad74413r.yaml | 1 - > .../devicetree/bindings/net/cdns,macb.yaml | 1 - > .../devicetree/bindings/net/nxp,dwmac-imx.yaml | 1 - > .../bindings/phy/intel,phy-thunderbay-emmc.yaml | 15 +++++++-------- > 7 files changed, 7 insertions(+), 15 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml index 711bb4d08c60..869c266e7ebc 100644 --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml +++ b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra-ccplex-cluster.yaml @@ -47,5 +47,4 @@ examples: compatible = "nvidia,tegra234-ccplex-cluster"; reg = <0x0e000000 0x5ffff>; nvidia,bpmp = <&bpmp>; - status = "okay"; }; diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml index 9ab123cd2325..5cdbc527a560 100644 --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra124-dpaux.yaml @@ -128,7 +128,6 @@ examples: resets = <&tegra_car 181>; reset-names = "dpaux"; power-domains = <&pd_sor>; - status = "disabled"; state_dpaux_aux: pinmux-aux { groups = "dpaux-io"; diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml index 8c0231345529..ce5c673f940c 100644 --- a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra186-display.yaml @@ -138,7 +138,6 @@ examples: <&bpmp TEGRA186_CLK_NVDISPLAY_DSC>, <&bpmp TEGRA186_CLK_NVDISPLAYHUB>; clock-names = "disp", "dsc", "hub"; - status = "disabled"; power-domains = <&bpmp TEGRA186_POWER_DOMAIN_DISP>; @@ -227,7 +226,6 @@ examples: clocks = <&bpmp TEGRA194_CLK_NVDISPLAY_DISP>, <&bpmp TEGRA194_CLK_NVDISPLAYHUB>; clock-names = "disp", "hub"; - status = "disabled"; power-domains = <&bpmp TEGRA194_POWER_DOMAIN_DISP>; diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml index 03bb90a7f4f8..d2a9f92c0a6d 100644 --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml @@ -114,7 +114,6 @@ examples: #size-cells = <0>; cs-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; - status = "okay"; ad74413r@0 { compatible = "adi,ad74413r"; diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml index 318f4efe7f6f..bef5e0f895be 100644 --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml @@ -203,7 +203,6 @@ examples: power-domains = <&zynqmp_firmware PD_ETH_1>; resets = <&zynqmp_reset ZYNQMP_RESET_GEM1>; reset-names = "gem1_rst"; - status = "okay"; phy-mode = "sgmii"; phys = <&psgtr 1 PHY_TYPE_SGMII 1 1>; fixed-link { diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml index 4c155441acbf..0270b0ca166b 100644 --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml @@ -92,5 +92,4 @@ examples: <&clk IMX8MP_CLK_ENET_QOS>; clock-names = "stmmaceth", "pclk", "ptp_ref", "tx"; phy-mode = "rgmii"; - status = "disabled"; }; diff --git a/Documentation/devicetree/bindings/phy/intel,phy-thunderbay-emmc.yaml b/Documentation/devicetree/bindings/phy/intel,phy-thunderbay-emmc.yaml index 34bdb5c4cae8..b09e5ba5e127 100644 --- a/Documentation/devicetree/bindings/phy/intel,phy-thunderbay-emmc.yaml +++ b/Documentation/devicetree/bindings/phy/intel,phy-thunderbay-emmc.yaml @@ -36,11 +36,10 @@ additionalProperties: false examples: - | - mmc_phy@80440800 { - #phy-cells = <0x0>; - compatible = "intel,thunderbay-emmc-phy"; - status = "okay"; - reg = <0x80440800 0x100>; - clocks = <&emmc>; - clock-names = "emmcclk"; - }; + mmc_phy@80440800 { + #phy-cells = <0x0>; + compatible = "intel,thunderbay-emmc-phy"; + reg = <0x80440800 0x100>; + clocks = <&emmc>; + clock-names = "emmcclk"; + };
There's no reason to have "status" properties in examples. "okay" is the default, and "disabled" turns off some schema checks ('required' specifically). A meta-schema check for this is pending, so hopefully the last time to fix these. Fix the indentation in intel,phy-thunderbay-emmc while we're here. Signed-off-by: Rob Herring <robh@kernel.org> --- .../arm/tegra/nvidia,tegra-ccplex-cluster.yaml | 1 - .../display/tegra/nvidia,tegra124-dpaux.yaml | 1 - .../display/tegra/nvidia,tegra186-display.yaml | 2 -- .../bindings/iio/addac/adi,ad74413r.yaml | 1 - .../devicetree/bindings/net/cdns,macb.yaml | 1 - .../devicetree/bindings/net/nxp,dwmac-imx.yaml | 1 - .../bindings/phy/intel,phy-thunderbay-emmc.yaml | 15 +++++++-------- 7 files changed, 7 insertions(+), 15 deletions(-)