| Message ID | 20221021095833.62406-3-vivek.2311@samsung.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | can: mcan: Add MCAN support for FSD SoC | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Series ignored based on subject |
On 21.10.2022 15:28:28, Vivek Yadav wrote: > Whenever the data is transferred or stored on message ram, there are > inherent risks of it being lost or corruption known as single-bit errors. > > ECC constantly scans data as it is processed to the message ram, using a > method known as parity checking and raise the error signals for corruption. > > Add error correction code config property to enable/disable the > error correction code (ECC) functionality for Message RAM used to create > valid ECC checksums. > > Signed-off-by: Chandrasekar R <rcsekar@samsung.com> > Signed-off-by: Vivek Yadav <vivek.2311@samsung.com> Can you please add an example to the yaml that makes use of the mram-ecc-cfg property? regards, Marc
You should add the DT people on Cc: - devicetree@vger.kernel.org - Rob Herring <robh+dt@kernel.org> On 21.10.2022 15:28:28, Vivek Yadav wrote: > Whenever the data is transferred or stored on message ram, there are > inherent risks of it being lost or corruption known as single-bit errors. > > ECC constantly scans data as it is processed to the message ram, using a > method known as parity checking and raise the error signals for corruption. > > Add error correction code config property to enable/disable the > error correction code (ECC) functionality for Message RAM used to create > valid ECC checksums. > > Signed-off-by: Chandrasekar R <rcsekar@samsung.com> > Signed-off-by: Vivek Yadav <vivek.2311@samsung.com> > --- > Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > index 26aa0830eea1..0ba3691863d7 100644 > --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > @@ -50,6 +50,10 @@ properties: > - const: hclk > - const: cclk > > + mram-ecc-cfg: This probably needs a prefix and a "$ref: /schemas/types.yaml#/definitions/phandle". > + items: > + - description: M_CAN ecc registers map with configuration register offset > + > bosch,mram-cfg: > description: | > Message RAM configuration data. > -- > 2.17.1 > > Marc
> -----Original Message----- > From: Marc Kleine-Budde <mkl@pengutronix.de> > Sent: 25 October 2022 12:55 > To: Vivek Yadav <vivek.2311@samsung.com> > Cc: rcsekar@samsung.com; wg@grandegger.com; davem@davemloft.net; > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > pankaj.dubey@samsung.com; ravi.patel@samsung.com; > alim.akhtar@samsung.com; linux-can@vger.kernel.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/7] dt-bindings: can: mcan: Add ECC functionality to > message ram > > On 21.10.2022 15:28:28, Vivek Yadav wrote: > > Whenever the data is transferred or stored on message ram, there are > > inherent risks of it being lost or corruption known as single-bit errors. > > > > ECC constantly scans data as it is processed to the message ram, using > > a method known as parity checking and raise the error signals for > corruption. > > > > Add error correction code config property to enable/disable the error > > correction code (ECC) functionality for Message RAM used to create > > valid ECC checksums. > > > > Signed-off-by: Chandrasekar R <rcsekar@samsung.com> > > Signed-off-by: Vivek Yadav <vivek.2311@samsung.com> > > Can you please add an example to the yaml that makes use of the mram-ecc- > cfg property? > Okay, I will add in next patch series. > regards, > Marc > Thanks for review. > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | > https://protect2.fireeye.com/v1/url?k=ec0872b8-8d836798-ec09f9f7- > 74fe485fb347-10f7a5cc45234a40&q=1&e=48595861-7733-4e80-bf96- > bd85b4d16570&u=https%3A%2F%2Fwww.pengutronix.de%2F | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> -----Original Message----- > From: Marc Kleine-Budde <mkl@pengutronix.de> > Sent: 25 October 2022 13:02 > To: Vivek Yadav <vivek.2311@samsung.com> > Cc: rcsekar@samsung.com; wg@grandegger.com; davem@davemloft.net; > edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; > pankaj.dubey@samsung.com; ravi.patel@samsung.com; > alim.akhtar@samsung.com; linux-can@vger.kernel.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/7] dt-bindings: can: mcan: Add ECC functionality to > message ram > > You should add the DT people on Cc: > - devicetree@vger.kernel.org > - Rob Herring <robh+dt@kernel.org> > Okay, I will add them in the next patch series. > On 21.10.2022 15:28:28, Vivek Yadav wrote: > > Whenever the data is transferred or stored on message ram, there are > > inherent risks of it being lost or corruption known as single-bit errors. > > > > ECC constantly scans data as it is processed to the message ram, using > > a method known as parity checking and raise the error signals for > corruption. > > > > Add error correction code config property to enable/disable the error > > correction code (ECC) functionality for Message RAM used to create > > valid ECC checksums. > > > > Signed-off-by: Chandrasekar R <rcsekar@samsung.com> > > Signed-off-by: Vivek Yadav <vivek.2311@samsung.com> > > --- > > Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > > b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > > index 26aa0830eea1..0ba3691863d7 100644 > > --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > > +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > > @@ -50,6 +50,10 @@ properties: > > - const: hclk > > - const: cclk > > > > + mram-ecc-cfg: > > This probably needs a prefix and a "$ref: > /schemas/types.yaml#/definitions/phandle". > okay I will add in the next patch series. > > + items: > > + - description: M_CAN ecc registers map with configuration > > + register offset > > + > > bosch,mram-cfg: > > description: | > > Message RAM configuration data. > > -- > > 2.17.1 > > > > > > Marc > Thanks for the review. > -- > Pengutronix e.K. | Marc Kleine-Budde | > Embedded Linux | > https://protect2.fireeye.com/v1/url?k=79b0bfe8-195222b5-79b134a7- > 000babd9f1ba-4774190ce98312a8&q=1&e=e3b63c25-f82a-4aa4-aaee- > 156c142ee4c6&u=https%3A%2F%2Fwww.pengutronix.de%2F | > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml index 26aa0830eea1..0ba3691863d7 100644 --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml @@ -50,6 +50,10 @@ properties: - const: hclk - const: cclk + mram-ecc-cfg: + items: + - description: M_CAN ecc registers map with configuration register offset + bosch,mram-cfg: description: | Message RAM configuration data.