| Message ID | 20221024135046.2159523-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b65ef50e0647cb6d7317ee5122f461286bb7f8d5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net/rds: remove variable total_copied | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 24 Oct 2022 14:50:46 +0100 you wrote: > Variable total_copied is just being incremented and it's never used > anywhere else. The variable and the increment are redundant so > remove it. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > net/rds/message.c | 2 -- > 1 file changed, 2 deletions(-) Here is the summary with links: - net/rds: remove variable total_copied https://git.kernel.org/netdev/net-next/c/b65ef50e0647 You are awesome, thank you!
diff --git a/net/rds/message.c b/net/rds/message.c index 44dbc612ef54..b47e4f0a1639 100644 --- a/net/rds/message.c +++ b/net/rds/message.c @@ -366,7 +366,6 @@ static int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter * struct scatterlist *sg; int ret = 0; int length = iov_iter_count(from); - int total_copied = 0; struct rds_msg_zcopy_info *info; rm->m_inc.i_hdr.h_len = cpu_to_be32(iov_iter_count(from)); @@ -404,7 +403,6 @@ static int rds_message_zcopy_from_user(struct rds_message *rm, struct iov_iter * ret = -EFAULT; goto err; } - total_copied += copied; length -= copied; sg_set_page(sg, pages, copied, start); rm->data.op_nents++;
Variable total_copied is just being incremented and it's never used anywhere else. The variable and the increment are redundant so remove it. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- net/rds/message.c | 2 -- 1 file changed, 2 deletions(-)