| Message ID | 20221025100024.1287157-4-idosch@nvidia.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | bridge: Add MAC Authentication Bypass (MAB) support with offload | expand |
On Tue, Oct 25, 2022 at 01:00:11PM +0300, Ido Schimmel wrote: > Currently, FDB entries that are notified to the bridge via > 'SWITCHDEV_FDB_ADD_TO_BRIDGE' are always marked as offloaded. With MAB > enabled, this will no longer be universally true. Device drivers will > report locked FDB entries to the bridge to let it know that the > corresponding hosts required authorization, but it does not mean that > these entries are necessarily programmed in the underlying hardware. > > Solve this by determining the offload indication based of the > 'offloaded' bit in the FDB notification. > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > --- > > Notes: > Needs auditing to see which device drivers are not setting this bit. > > net/bridge/br.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bridge/br.c b/net/bridge/br.c > index 96e91d69a9a8..145999b8c355 100644 > --- a/net/bridge/br.c > +++ b/net/bridge/br.c > @@ -172,7 +172,7 @@ static int br_switchdev_event(struct notifier_block *unused, > break; > } > br_fdb_offloaded_set(br, p, fdb_info->addr, > - fdb_info->vid, true); > + fdb_info->vid, fdb_info->offloaded); ofdpa_port_fdb_learn_work() doesn't set info->offloaded on SWITCHDEV_FDB_ADD_TO_BRIDGE, the rest do. > break; > case SWITCHDEV_FDB_DEL_TO_BRIDGE: > fdb_info = ptr; > -- > 2.37.3 >
On Thu, Oct 27, 2022 at 11:10:41PM +0000, Vladimir Oltean wrote: > On Tue, Oct 25, 2022 at 01:00:11PM +0300, Ido Schimmel wrote: > > Currently, FDB entries that are notified to the bridge via > > 'SWITCHDEV_FDB_ADD_TO_BRIDGE' are always marked as offloaded. With MAB > > enabled, this will no longer be universally true. Device drivers will > > report locked FDB entries to the bridge to let it know that the > > corresponding hosts required authorization, but it does not mean that > > these entries are necessarily programmed in the underlying hardware. > > > > Solve this by determining the offload indication based of the > > 'offloaded' bit in the FDB notification. > > > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > > --- > > > > Notes: > > Needs auditing to see which device drivers are not setting this bit. > > > > net/bridge/br.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/bridge/br.c b/net/bridge/br.c > > index 96e91d69a9a8..145999b8c355 100644 > > --- a/net/bridge/br.c > > +++ b/net/bridge/br.c > > @@ -172,7 +172,7 @@ static int br_switchdev_event(struct notifier_block *unused, > > break; > > } > > br_fdb_offloaded_set(br, p, fdb_info->addr, > > - fdb_info->vid, true); > > + fdb_info->vid, fdb_info->offloaded); > > ofdpa_port_fdb_learn_work() doesn't set info->offloaded on > SWITCHDEV_FDB_ADD_TO_BRIDGE, the rest do. Double-checked and this is the only one missing. Will send a patch. Thanks > > > break; > > case SWITCHDEV_FDB_DEL_TO_BRIDGE: > > fdb_info = ptr; > > -- > > 2.37.3 > >
diff --git a/net/bridge/br.c b/net/bridge/br.c index 96e91d69a9a8..145999b8c355 100644 --- a/net/bridge/br.c +++ b/net/bridge/br.c @@ -172,7 +172,7 @@ static int br_switchdev_event(struct notifier_block *unused, break; } br_fdb_offloaded_set(br, p, fdb_info->addr, - fdb_info->vid, true); + fdb_info->vid, fdb_info->offloaded); break; case SWITCHDEV_FDB_DEL_TO_BRIDGE: fdb_info = ptr;
Currently, FDB entries that are notified to the bridge via 'SWITCHDEV_FDB_ADD_TO_BRIDGE' are always marked as offloaded. With MAB enabled, this will no longer be universally true. Device drivers will report locked FDB entries to the bridge to let it know that the corresponding hosts required authorization, but it does not mean that these entries are necessarily programmed in the underlying hardware. Solve this by determining the offload indication based of the 'offloaded' bit in the FDB notification. Signed-off-by: Ido Schimmel <idosch@nvidia.com> --- Notes: Needs auditing to see which device drivers are not setting this bit. net/bridge/br.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)