Message ID | 20221025120109.779337-1-festevam@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Commit | c926b4c3fa1fdce5e128bc954cad94ca16acce41 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [net-next] net: dp83822: Print the SOR1 strap status | expand |
On Tue, Oct 25, 2022 at 09:01:09AM -0300, Fabio Estevam wrote: > During the bring-up of the Ethernet PHY, it is very useful to > see the bootstrap status information, as it can help identifying > hardware bootstrap mistakes. > > Allow printing the SOR1 register, which contains the strap status > to ease the bring-up. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (master) by Paolo Abeni <pabeni@redhat.com>: On Tue, 25 Oct 2022 09:01:09 -0300 you wrote: > During the bring-up of the Ethernet PHY, it is very useful to > see the bootstrap status information, as it can help identifying > hardware bootstrap mistakes. > > Allow printing the SOR1 register, which contains the strap status > to ease the bring-up. > > [...] Here is the summary with links: - [net-next] net: dp83822: Print the SOR1 strap status https://git.kernel.org/netdev/net-next/c/c926b4c3fa1f You are awesome, thank you!
diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c index b60db8b6f477..a6f05e35d91f 100644 --- a/drivers/net/phy/dp83822.c +++ b/drivers/net/phy/dp83822.c @@ -524,6 +524,8 @@ static int dp83822_read_straps(struct phy_device *phydev) if (val < 0) return val; + phydev_dbg(phydev, "SOR1 strap register: 0x%04x\n", val); + fx_enabled = (val & DP83822_COL_STRAP_MASK) >> DP83822_COL_SHIFT; if (fx_enabled == DP83822_STRAP_MODE2 || fx_enabled == DP83822_STRAP_MODE3)
During the bring-up of the Ethernet PHY, it is very useful to see the bootstrap status information, as it can help identifying hardware bootstrap mistakes. Allow printing the SOR1 register, which contains the strap status to ease the bring-up. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- drivers/net/phy/dp83822.c | 2 ++ 1 file changed, 2 insertions(+)