diff mbox series

[v2] Bluetooth: hci_conn: add missing hci_dev_put() in iso_listen_bis()

Message ID 20221109023906.1556201-1-bobo.shaobowang@huawei.com (mailing list archive)
State Awaiting Upstream
Delegated to: Netdev Maintainers
Headers show
Series [v2] Bluetooth: hci_conn: add missing hci_dev_put() in iso_listen_bis() | expand

Checks

Context Check Description
netdev/tree_selection success Guessed tree name to be net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 5 maintainers not CCed: marcel@holtmann.org davem@davemloft.net edumazet@google.com kuba@kernel.org johan.hedberg@gmail.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Wangshaobo (bobo) Nov. 9, 2022, 2:39 a.m. UTC
hci_get_route() takes reference, we should use hci_dev_put() to release
it when not need anymore.

Fixes: f764a6c2c1e4 ("Bluetooth: ISO: Add broadcast support")
Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
---

v2:
  - always release reference as it is not need anymore when
  - iso_listen_bis() finish.

v1: https://lore.kernel.org/netdev/20221108112308.3910185-1-bobo.shaobowang@huawei.com/T/

 net/bluetooth/iso.c | 1 +
 1 file changed, 1 insertion(+)

Comments

patchwork-bot+bluetooth@kernel.org Nov. 14, 2022, 10:10 p.m. UTC | #1
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 9 Nov 2022 10:39:06 +0800 you wrote:
> hci_get_route() takes reference, we should use hci_dev_put() to release
> it when not need anymore.
> 
> Fixes: f764a6c2c1e4 ("Bluetooth: ISO: Add broadcast support")
> Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com>
> ---
> 
> [...]

Here is the summary with links:
  - [v2] Bluetooth: hci_conn: add missing hci_dev_put() in iso_listen_bis()
    https://git.kernel.org/bluetooth/bluetooth-next/c/e32c8d8c6f29

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index f825857db6d0..26db929b97c4 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -879,6 +879,7 @@  static int iso_listen_bis(struct sock *sk)
 				 iso_pi(sk)->bc_sid);
 
 	hci_dev_unlock(hdev);
+	hci_dev_put(hdev);
 
 	return err;
 }