| Message ID | 20221109085835.213252-1-chenzhongjin@huawei.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Bluetooth: selftest: Fix memleak in test_ecdh() | expand |
diff --git a/net/bluetooth/selftest.c b/net/bluetooth/selftest.c index f49604d44b87..586125a611dd 100644 --- a/net/bluetooth/selftest.c +++ b/net/bluetooth/selftest.c @@ -233,8 +233,6 @@ static int __init test_ecdh(void) goto done; } - crypto_free_kpp(tfm); - rettime = ktime_get(); delta = ktime_sub(rettime, calltime); duration = (unsigned long long) ktime_to_ns(delta) >> 10; @@ -248,6 +246,8 @@ static int __init test_ecdh(void) else snprintf(test_ecdh_buffer, sizeof(test_ecdh_buffer), "FAIL\n"); + crypto_free_kpp(tfm); + debugfs_create_file("selftest_ecdh", 0444, bt_debugfs, NULL, &test_ecdh_fops);
kmemleak reported: Bluetooth: ECDH sample 1 failed kmemleak: 2 new suspected memory leaks (see /sys/kernel/debug/kmemleak) unreferenced object 0xffff888102149100 (size 96): comm "modprobe", pid 418, jiffies 4295082093 (age 610.644s) ... backtrace: [<00000000c8e4e5a6>] __kmalloc_node+0x4c/0x1c0 [<000000006cdcfddc>] crypto_create_tfm_node+0x89/0x320 [<00000000e222ad46>] crypto_alloc_tfm_node+0xfd/0x2f0 [<00000000871fc045>] 0xffffffffc05c94ab [<00000000e889f45e>] 0xffffffffc05c8024 [<000000001ff0c346>] do_one_initcall+0xd0/0x4e0 ... In test_ecdh(), when test sample fails, crypto_free_kpp(tfm) is not called, which makes tfm memory leaked. Fix it by moving crypto_free_kpp behind done label. Fixes: 47eb2ac80918 ("Bluetooth: move ecdh allocation outside of ecdh_helper") Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com> --- net/bluetooth/selftest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)