diff mbox series

[bpf-next,v4,7/7] selftests/bpf: Add rcu_read_lock test to s390x deny list

Message ID 20221110180201.917531-1-yhs@fb.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series bpf: Add bpf_rcu_read_lock() support | expand

Checks

Context Check Description
bpf/vmtest-bpf-next-PR fail PR summary
netdev/tree_selection success Clearly marked for bpf-next, async
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Series has a cover letter
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 10 maintainers not CCed: sdf@google.com kpsingh@kernel.org mykolal@fb.com haoluo@google.com linux-kselftest@vger.kernel.org shuah@kernel.org jolsa@kernel.org martin.lau@linux.dev song@kernel.org john.fastabend@gmail.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-VM_Test-16 success Logs for test_progs on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-26 success Logs for test_progs_no_alu32_parallel on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-36 success Logs for test_verifier on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-11 success Logs for test_maps on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-21 success Logs for test_progs_no_alu32 on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-31 success Logs for test_progs_parallel on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-7 success Logs for llvm-toolchain
bpf/vmtest-bpf-next-VM_Test-8 success Logs for set-matrix
bpf/vmtest-bpf-next-VM_Test-2 success Logs for build for aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-3 success Logs for build for aarch64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-5 success Logs for build for x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-6 success Logs for build for x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-4 success Logs for build for s390x with gcc
bpf/vmtest-bpf-next-VM_Test-9 success Logs for test_maps on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-10 success Logs for test_maps on aarch64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-12 success Logs for test_maps on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-13 success Logs for test_maps on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-14 fail Logs for test_progs on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-15 fail Logs for test_progs on aarch64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-17 fail Logs for test_progs on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-18 success Logs for test_progs on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-19 fail Logs for test_progs_no_alu32 on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-20 fail Logs for test_progs_no_alu32 on aarch64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-22 success Logs for test_progs_no_alu32 on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-23 success Logs for test_progs_no_alu32 on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-24 success Logs for test_progs_no_alu32_parallel on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-25 success Logs for test_progs_no_alu32_parallel on aarch64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-27 success Logs for test_progs_no_alu32_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-28 success Logs for test_progs_no_alu32_parallel on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-29 success Logs for test_progs_parallel on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-30 success Logs for test_progs_parallel on aarch64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-32 success Logs for test_progs_parallel on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-33 success Logs for test_progs_parallel on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-34 success Logs for test_verifier on aarch64 with gcc
bpf/vmtest-bpf-next-VM_Test-35 success Logs for test_verifier on aarch64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-37 success Logs for test_verifier on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-38 success Logs for test_verifier on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-1 pending Logs for ShellCheck

Commit Message

Yonghong Song Nov. 10, 2022, 6:02 p.m. UTC 
The new rcu_read_lock test will fail on s390x with the following error message:

  ...
  test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
  test_local_storage:PASS:skel_open 0 nsec
  libbpf: prog 'cgrp_succ': failed to find kernel BTF type ID of '__s390x_sys_getpgid': -3
  libbpf: prog 'cgrp_succ': failed to prepare load attributes: -3
  libbpf: prog 'cgrp_succ': failed to load: -3
  libbpf: failed to load object 'rcu_read_lock'
  libbpf: failed to load BPF skeleton 'rcu_read_lock': -3
  test_local_storage:FAIL:skel_load unexpected error: -3 (errno 3)
  ...

So add it to the s390x deny list.

Signed-off-by: Yonghong Song <yhs@fb.com>
---
 tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
 1 file changed, 1 insertion(+)

Comments

Manu Bretelle Nov. 10, 2022, 7:37 p.m. UTC | #1 
On Thu, Nov 10, 2022 at 10:02:01AM -0800, Yonghong Song wrote:
> The new rcu_read_lock test will fail on s390x with the following error message:
> 
>   ...
>   test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
>   test_local_storage:PASS:skel_open 0 nsec
>   libbpf: prog 'cgrp_succ': failed to find kernel BTF type ID of '__s390x_sys_getpgid': -3
>   libbpf: prog 'cgrp_succ': failed to prepare load attributes: -3
>   libbpf: prog 'cgrp_succ': failed to load: -3
>   libbpf: failed to load object 'rcu_read_lock'
>   libbpf: failed to load BPF skeleton 'rcu_read_lock': -3
>   test_local_storage:FAIL:skel_load unexpected error: -3 (errno 3)
>   ...
> 
> So add it to the s390x deny list.
> 
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
>  tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
> index be4e3d47ea3e..dd5db40b5a09 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.s390x
> +++ b/tools/testing/selftests/bpf/DENYLIST.s390x
> @@ -41,6 +41,7 @@ module_attach                            # skel_attach skeleton attach failed: -
>  mptcp
>  netcnt                                   # failed to load BPF skeleton 'netcnt_prog': -7                               (?)
>  probe_user                               # check_kprobe_res wrong kprobe res from probe read                           (?)
> +rcu_read_lock                            # failed to find kernel BTF type ID of '__x64_sys_getpgid': -3                (?)

This also seems to fail on aarch64:
```
2022-11-10T18:39:39.2406543Z test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
2022-11-10T18:39:39.2409781Z test_local_storage:PASS:skel_open 0 nsec
2022-11-10T18:39:39.2413002Z test_local_storage:PASS:skel_load 0 nsec
2022-11-10T18:39:39.2418758Z libbpf: prog 'cgrp_succ': failed to attach: ERROR: strerror_r(-524)=22
2022-11-10T18:39:39.2422765Z libbpf: prog 'cgrp_succ': failed to auto-attach: -524
2022-11-10T18:39:39.2428250Z test_local_storage:FAIL:skel_attach unexpected error: -524 (errno 524)
2022-11-10T18:39:39.2431555Z #145/1   rcu_read_lock/local_storage:FAIL
2022-11-10T18:39:39.2435392Z #145/2   rcu_read_lock/runtime_diff_rcu_tag:OK
2022-11-10T18:39:39.2439296Z #145/3   rcu_read_lock/negative_tests_region:OK
2022-11-10T18:39:39.2443876Z #145/4   rcu_read_lock/negative_tests_rcuptr_misuse:SKIP
2022-11-10T18:39:39.2446212Z #145     rcu_read_lock:FAIL
```

Can you add the test to DENYLIST.aarch64 also?


>  recursion                                # skel_attach unexpected error: -524                                          (trampoline)
>  ringbuf                                  # skel_load skeleton load failed                                              (?)
>  select_reuseport                         # intermittently fails on new s390x setup
> -- 
> 2.30.2
>
Yonghong Song Nov. 10, 2022, 8:06 p.m. UTC | #2 
On 11/10/22 11:37 AM, Manu Bretelle wrote:
> On Thu, Nov 10, 2022 at 10:02:01AM -0800, Yonghong Song wrote:
>> The new rcu_read_lock test will fail on s390x with the following error message:
>>
>>    ...
>>    test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
>>    test_local_storage:PASS:skel_open 0 nsec
>>    libbpf: prog 'cgrp_succ': failed to find kernel BTF type ID of '__s390x_sys_getpgid': -3
>>    libbpf: prog 'cgrp_succ': failed to prepare load attributes: -3
>>    libbpf: prog 'cgrp_succ': failed to load: -3
>>    libbpf: failed to load object 'rcu_read_lock'
>>    libbpf: failed to load BPF skeleton 'rcu_read_lock': -3
>>    test_local_storage:FAIL:skel_load unexpected error: -3 (errno 3)
>>    ...
>>
>> So add it to the s390x deny list.
>>
>> Signed-off-by: Yonghong Song <yhs@fb.com>
>> ---
>>   tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
>> index be4e3d47ea3e..dd5db40b5a09 100644
>> --- a/tools/testing/selftests/bpf/DENYLIST.s390x
>> +++ b/tools/testing/selftests/bpf/DENYLIST.s390x
>> @@ -41,6 +41,7 @@ module_attach                            # skel_attach skeleton attach failed: -
>>   mptcp
>>   netcnt                                   # failed to load BPF skeleton 'netcnt_prog': -7                               (?)
>>   probe_user                               # check_kprobe_res wrong kprobe res from probe read                           (?)
>> +rcu_read_lock                            # failed to find kernel BTF type ID of '__x64_sys_getpgid': -3                (?)
> 
> This also seems to fail on aarch64:
> ```
> 2022-11-10T18:39:39.2406543Z test_rcu_read_lock:PASS:join_cgroup /rcu_read_lock 0 nsec
> 2022-11-10T18:39:39.2409781Z test_local_storage:PASS:skel_open 0 nsec
> 2022-11-10T18:39:39.2413002Z test_local_storage:PASS:skel_load 0 nsec
> 2022-11-10T18:39:39.2418758Z libbpf: prog 'cgrp_succ': failed to attach: ERROR: strerror_r(-524)=22
> 2022-11-10T18:39:39.2422765Z libbpf: prog 'cgrp_succ': failed to auto-attach: -524
> 2022-11-10T18:39:39.2428250Z test_local_storage:FAIL:skel_attach unexpected error: -524 (errno 524)
> 2022-11-10T18:39:39.2431555Z #145/1   rcu_read_lock/local_storage:FAIL
> 2022-11-10T18:39:39.2435392Z #145/2   rcu_read_lock/runtime_diff_rcu_tag:OK
> 2022-11-10T18:39:39.2439296Z #145/3   rcu_read_lock/negative_tests_region:OK
> 2022-11-10T18:39:39.2443876Z #145/4   rcu_read_lock/negative_tests_rcuptr_misuse:SKIP
> 2022-11-10T18:39:39.2446212Z #145     rcu_read_lock:FAIL
> ```
> 
> Can you add the test to DENYLIST.aarch64 also?

Thanks. Will add to the next revision.

> 
> 
>>   recursion                                # skel_attach unexpected error: -524                                          (trampoline)
>>   ringbuf                                  # skel_load skeleton load failed                                              (?)
>>   select_reuseport                         # intermittently fails on new s390x setup
>> -- 
>> 2.30.2
>>
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
index be4e3d47ea3e..dd5db40b5a09 100644
--- a/tools/testing/selftests/bpf/DENYLIST.s390x
+++ b/tools/testing/selftests/bpf/DENYLIST.s390x
@@ -41,6 +41,7 @@  module_attach                            # skel_attach skeleton attach failed: -
 mptcp
 netcnt                                   # failed to load BPF skeleton 'netcnt_prog': -7                               (?)
 probe_user                               # check_kprobe_res wrong kprobe res from probe read                           (?)
+rcu_read_lock                            # failed to find kernel BTF type ID of '__x64_sys_getpgid': -3                (?)
 recursion                                # skel_attach unexpected error: -524                                          (trampoline)
 ringbuf                                  # skel_load skeleton load failed                                              (?)
 select_reuseport                         # intermittently fails on new s390x setup