diff mbox series

[net-next,01/15] net/mlx5: Bridge, Use debug instead of warn if entry doesn't exists

Message ID 20221112102147.496378-2-saeed@kernel.org (mailing list archive)
State Accepted
Commit ea645f97bcec90a818dc6915d84cd0f752d9ccfd
Delegated to: Netdev Maintainers
Headers show
Series [net-next,01/15] net/mlx5: Bridge, Use debug instead of warn if entry doesn't exists | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Pull request is its own cover letter
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 20 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Saeed Mahameed Nov. 12, 2022, 10:21 a.m. UTC
From: Roi Dayan <roid@nvidia.com>

There is no need for the warn if entry already removed.
Use debug print like in the update flow.
Also update the messages so user can identify if the it's
from the update flow or remove flow.

Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 14, 2022, 11:40 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (master)
by Saeed Mahameed <saeedm@nvidia.com>:

On Sat, 12 Nov 2022 02:21:33 -0800 you wrote:
> From: Roi Dayan <roid@nvidia.com>
> 
> There is no need for the warn if entry already removed.
> Use debug print like in the update flow.
> Also update the messages so user can identify if the it's
> from the update flow or remove flow.
> 
> [...]

Here is the summary with links:
  - [net-next,01/15] net/mlx5: Bridge, Use debug instead of warn if entry doesn't exists
    https://git.kernel.org/netdev/net-next/c/ea645f97bcec
  - [net-next,02/15] net/mlx5: Fix spelling mistake "destoy" -> "destroy"
    https://git.kernel.org/netdev/net-next/c/d23b928befda
  - [net-next,03/15] net/mlx5: Unregister traps on driver unload flow
    https://git.kernel.org/netdev/net-next/c/71b75f0e02ed
  - [net-next,04/15] net/mlx5: Expose vhca_id to debugfs
    https://git.kernel.org/netdev/net-next/c/dd3dd7263cde
  - [net-next,05/15] net/mlx5e: remove unused list in arfs
    https://git.kernel.org/netdev/net-next/c/60551e95a864
  - [net-next,06/15] net/mlx5e: Use clamp operation instead of open coding it
    https://git.kernel.org/netdev/net-next/c/9458108040b3
  - [net-next,07/15] net/mlx5e: Support enhanced CQE compression
    https://git.kernel.org/netdev/net-next/c/2c925db0a7d6
  - [net-next,08/15] net/mlx5e: Move params kernel log print to probe function
    https://git.kernel.org/netdev/net-next/c/38438d39a9a0
  - [net-next,09/15] net/mlx5e: Add error flow when failing update_rx
    https://git.kernel.org/netdev/net-next/c/e74ae1faeb71
  - [net-next,10/15] net/mlx5e: TC, Remove redundant WARN_ON()
    https://git.kernel.org/netdev/net-next/c/989722906166
  - [net-next,11/15] net/mlx5e: kTLS, Remove unused work field
    https://git.kernel.org/netdev/net-next/c/1f74399fd1ed
  - [net-next,12/15] net/mlx5e: kTLS, Remove unnecessary per-callback completion
    https://git.kernel.org/netdev/net-next/c/4d78a2ebbd2b
  - [net-next,13/15] net/mlx5e: kTLS, Use a single async context object per a callback bulk
    https://git.kernel.org/netdev/net-next/c/341361533011
  - [net-next,14/15] net/mlx5e: CT, optimize pre_ct table lookup
    https://git.kernel.org/netdev/net-next/c/05bb74c29d84
  - [net-next,15/15] net/mlx5e: ethtool: get_link_ext_stats for PHY down events
    https://git.kernel.org/netdev/net-next/c/e07c4924a77d

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
index 4fbff7bcc155..b176648d1343 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/bridge.c
@@ -1722,7 +1722,7 @@  void mlx5_esw_bridge_fdb_update_used(struct net_device *dev, u16 vport_num, u16
 	entry = mlx5_esw_bridge_fdb_lookup(bridge, fdb_info->addr, fdb_info->vid);
 	if (!entry) {
 		esw_debug(br_offloads->esw->dev,
-			  "FDB entry with specified key not found (MAC=%pM,vid=%u,vport=%u)\n",
+			  "FDB update entry with specified key not found (MAC=%pM,vid=%u,vport=%u)\n",
 			  fdb_info->addr, fdb_info->vid, vport_num);
 		return;
 	}
@@ -1775,9 +1775,9 @@  void mlx5_esw_bridge_fdb_remove(struct net_device *dev, u16 vport_num, u16 esw_o
 	bridge = port->bridge;
 	entry = mlx5_esw_bridge_fdb_lookup(bridge, fdb_info->addr, fdb_info->vid);
 	if (!entry) {
-		esw_warn(esw->dev,
-			 "FDB entry with specified key not found (MAC=%pM,vid=%u,vport=%u)\n",
-			 fdb_info->addr, fdb_info->vid, vport_num);
+		esw_debug(esw->dev,
+			  "FDB remove entry with specified key not found (MAC=%pM,vid=%u,vport=%u)\n",
+			  fdb_info->addr, fdb_info->vid, vport_num);
 		return;
 	}