Message ID | 20221113101438.30910-4-sahid.ferdjaoui@industrialdiscipline.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | BPF |
Headers | show |
Series | clean-up bpftool from legacy support | expand |
On Sun, 13 Nov 2022 at 10:15, Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com> wrote: > > It is expected that errno be passed to strerror(). This also cleans > this part of code from using libbpf_get_error(). > > Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com> > Acked-by: Yonghong Song <yhs@fb.com> Reviewed-by: Quentin Monnet <quentin@isovalent.com> Thanks
diff --git a/tools/bpf/bpftool/struct_ops.c b/tools/bpf/bpftool/struct_ops.c index 1a235d0c6742..a6c6d5b9551e 100644 --- a/tools/bpf/bpftool/struct_ops.c +++ b/tools/bpf/bpftool/struct_ops.c @@ -510,10 +510,9 @@ static int do_register(int argc, char **argv) continue; link = bpf_map__attach_struct_ops(map); - if (libbpf_get_error(link)) { + if (!link) { p_err("can't register struct_ops %s: %s", - bpf_map__name(map), - strerror(-PTR_ERR(link))); + bpf_map__name(map), strerror(errno)); nr_errs++; continue; }