| Message ID | 20221113184727.44923-4-robimarko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/5] dt-bindings: net: ipq4019-mdio: document IPQ6018 compatible | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 13/11/2022 19:47, Robert Marko wrote: > IPQ5018, IPQ6018 and IPQ8074 require clock-names to be set as driver is > requesting the clock based on it and not index, so document that and make > it required for the listed SoC-s. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > index b34955b0b827..d233009b0d49 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml > @@ -59,8 +59,12 @@ allOf: > clocks: > items: > - description: MDIO clock source frequency fixed to 100MHZ Similarly to clocks, define clock-names in top-level and disallow them for other variants. Do not define properties in allOf:if:then - it makes schema difficult to maintain and read. > + clock-names: > + items: > + - const: gcc_mdio_ahb_clk > required: > - clocks > + - clock-names > > unevaluatedProperties: false > Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml index b34955b0b827..d233009b0d49 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml @@ -59,8 +59,12 @@ allOf: clocks: items: - description: MDIO clock source frequency fixed to 100MHZ + clock-names: + items: + - const: gcc_mdio_ahb_clk required: - clocks + - clock-names unevaluatedProperties: false
IPQ5018, IPQ6018 and IPQ8074 require clock-names to be set as driver is requesting the clock based on it and not index, so document that and make it required for the listed SoC-s. Signed-off-by: Robert Marko <robimarko@gmail.com> --- Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml | 4 ++++ 1 file changed, 4 insertions(+)