| Message ID | 20221115210715.172728-1-bpoirier@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2ed09c3bf8aca185b2f3eb369ae435503f9b9826 |
| Delegated to: | David Ahern |
| Headers | show |
| Series | [iproute2-next] bridge: Remove unused function argument | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to iproute2/iproute2-next.git (main) by David Ahern <dsahern@kernel.org>: On Tue, 15 Nov 2022 16:07:15 -0500 you wrote: > print_vnifilter_rtm() was probably modeled on print_vlan_rtm() but the > 'monitor' argument is unused in the vnifilter case. > > Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com> > Reviewed-by: Ido Schimmel <idosch@nvidia.com> > --- > bridge/br_common.h | 2 +- > bridge/monitor.c | 2 +- > bridge/vni.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) Here is the summary with links: - [iproute2-next] bridge: Remove unused function argument https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=2ed09c3bf8ac You are awesome, thank you!
diff --git a/bridge/br_common.h b/bridge/br_common.h index da677df8..1bdee658 100644 --- a/bridge/br_common.h +++ b/bridge/br_common.h @@ -14,7 +14,7 @@ void print_stp_state(__u8 state); int parse_stp_state(const char *arg); int print_vlan_rtm(struct nlmsghdr *n, void *arg, bool monitor, bool global_only); -int print_vnifilter_rtm(struct nlmsghdr *n, void *arg, bool monitor); +int print_vnifilter_rtm(struct nlmsghdr *n, void *arg); void br_print_router_port_stats(struct rtattr *pattr); void print_headers(FILE *fp, const char *label); diff --git a/bridge/monitor.c b/bridge/monitor.c index e321516a..d82f45cc 100644 --- a/bridge/monitor.c +++ b/bridge/monitor.c @@ -63,7 +63,7 @@ static int accept_msg(struct rtnl_ctrl_data *ctrl, case RTM_NEWTUNNEL: case RTM_DELTUNNEL: - return print_vnifilter_rtm(n, arg, true); + return print_vnifilter_rtm(n, arg); default: return 0; diff --git a/bridge/vni.c b/bridge/vni.c index e776797a..940f251c 100644 --- a/bridge/vni.c +++ b/bridge/vni.c @@ -303,7 +303,7 @@ static void print_vni(struct rtattr *t, int ifindex) print_string(PRINT_FP, NULL, "%s", _SL_); } -int print_vnifilter_rtm(struct nlmsghdr *n, void *arg, bool monitor) +int print_vnifilter_rtm(struct nlmsghdr *n, void *arg) { struct tunnel_msg *tmsg = NLMSG_DATA(n); int len = n->nlmsg_len; @@ -364,7 +364,7 @@ int print_vnifilter_rtm(struct nlmsghdr *n, void *arg, bool monitor) static int print_vnifilter_rtm_filter(struct nlmsghdr *n, void *arg) { - return print_vnifilter_rtm(n, arg, false); + return print_vnifilter_rtm(n, arg); } static int vni_show(int argc, char **argv)