| Message ID | 20221116015835.1187783-1-jiawenwu@trustnetic.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0b6ffefbb018462856dd8ee22735f8c9aecb2c80 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: libwx: Fix dead code for duplicate check | expand |
On Wed, Nov 16, 2022 at 09:58:35AM +0800, Jiawen Wu wrote: > Fix duplicate check on polling timeout. > > Fixes: 1efa9bfe58c5 ("net: libwx: Implement interaction with firmware") > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> > --- > drivers/net/ethernet/wangxun/libwx/wx_hw.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c > index 1eb7388f1dd5..c57dc3238b3f 100644 > --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c > +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c > @@ -203,8 +203,6 @@ int wx_host_interface_command(struct wx_hw *wxhw, u32 *buffer, > > status = read_poll_timeout(rd32, hicr, hicr & WX_MNG_MBOX_CTL_FWRDY, 1000, > timeout * 1000, false, wxhw, WX_MNG_MBOX_CTL); > - if (status) > - goto rel_out; BTW, this driver should use readx_poll_timeout() instead of read_poll_timeout(...). Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Wed, 16 Nov 2022 09:58:35 +0800 you wrote: > Fix duplicate check on polling timeout. > > Fixes: 1efa9bfe58c5 ("net: libwx: Implement interaction with firmware") > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> > --- > drivers/net/ethernet/wangxun/libwx/wx_hw.c | 2 -- > 1 file changed, 2 deletions(-) Here is the summary with links: - [net-next] net: libwx: Fix dead code for duplicate check https://git.kernel.org/netdev/net-next/c/0b6ffefbb018 You are awesome, thank you!
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c index 1eb7388f1dd5..c57dc3238b3f 100644 --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c @@ -203,8 +203,6 @@ int wx_host_interface_command(struct wx_hw *wxhw, u32 *buffer, status = read_poll_timeout(rd32, hicr, hicr & WX_MNG_MBOX_CTL_FWRDY, 1000, timeout * 1000, false, wxhw, WX_MNG_MBOX_CTL); - if (status) - goto rel_out; /* Check command completion */ if (status) {
Fix duplicate check on polling timeout. Fixes: 1efa9bfe58c5 ("net: libwx: Implement interaction with firmware") Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> --- drivers/net/ethernet/wangxun/libwx/wx_hw.c | 2 -- 1 file changed, 2 deletions(-)