| Message ID | 20221118014641.3035-1-zeming@nfschina.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2] sctp: sm_statefuns: Remove unnecessary ‘NULL’ values from Pointer | expand |
On Fri, 18 Nov 2022 09:46:42 +0800 Li zeming wrote: > - struct sctp_packet *packet = NULL; > + struct sctp_packet *packet; > struct sctp_chunk *chunk = arg; > struct sctp_chunk *shut; Please don't sent such patches to networking.
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c index f6ee7f4040c1..714605746fee 100644 --- a/net/sctp/sm_statefuns.c +++ b/net/sctp/sm_statefuns.c @@ -3781,7 +3781,7 @@ static enum sctp_disposition sctp_sf_shut_8_4_5( void *arg, struct sctp_cmd_seq *commands) { - struct sctp_packet *packet = NULL; + struct sctp_packet *packet; struct sctp_chunk *chunk = arg; struct sctp_chunk *shut;
The 'packet' pointer is always set in the later code, no need to initialize it at definition time. Signed-off-by: Li zeming <zeming@nfschina.com> --- v2: Modify the submitted description. net/sctp/sm_statefuns.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)