diff mbox series

[net,2/4] net: wwan: iosm: fix dma_alloc_coherent incompatible pointer type

Message ID 20221122174657.3496826-1-m.chetan.kumar@linux.intel.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series [net,1/4] net: wwan: iosm: fix kernel test robot reported error | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter warning Series does not have a cover letter
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 1 blamed authors not CCed: m.chetan.kumar@intel.com; 1 maintainers not CCed: m.chetan.kumar@intel.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Kumar, M Chetan Nov. 22, 2022, 5:46 p.m. UTC
From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>

Fix build error reported on armhf while preparing 6.1-rc5
for Debian.

iosm_ipc_protocol.c:244:36: error: passing argument 3 of
'dma_alloc_coherent' from incompatible pointer type.

Change phy_ap_shm type from phys_addr_t to dma_addr_t.

Fixes: faed4c6f6f48 ("net: iosm: shared memory protocol")
Reported-by: Bonaccorso Salvatore <carnil@debian.org>
Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
---
 drivers/net/wwan/iosm/iosm_ipc_protocol.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Salvatore Bonaccorso Nov. 23, 2022, 9:58 p.m. UTC | #1
Hi,

On Tue, Nov 22, 2022 at 11:16:57PM +0530, m.chetan.kumar@linux.intel.com wrote:
> From: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
> 
> Fix build error reported on armhf while preparing 6.1-rc5
> for Debian.
> 
> iosm_ipc_protocol.c:244:36: error: passing argument 3 of
> 'dma_alloc_coherent' from incompatible pointer type.
> 
> Change phy_ap_shm type from phys_addr_t to dma_addr_t.
> 
> Fixes: faed4c6f6f48 ("net: iosm: shared memory protocol")
> Reported-by: Bonaccorso Salvatore <carnil@debian.org>
> Signed-off-by: M Chetan Kumar <m.chetan.kumar@linux.intel.com>
> ---
>  drivers/net/wwan/iosm/iosm_ipc_protocol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wwan/iosm/iosm_ipc_protocol.h b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> index 9b3a6d86ece7..289397c4ea6c 100644
> --- a/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> +++ b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
> @@ -122,7 +122,7 @@ struct iosm_protocol {
>  	struct iosm_imem *imem;
>  	struct ipc_rsp *rsp_ring[IPC_MEM_MSG_ENTRIES];
>  	struct device *dev;
> -	phys_addr_t phy_ap_shm;
> +	dma_addr_t phy_ap_shm;
>  	u32 old_msg_tail;
>  };

The patch resolves the build failure we did notice. Only was able to
test the build though, no functional test on armhf.

Regards,
Salvatore
diff mbox series

Patch

diff --git a/drivers/net/wwan/iosm/iosm_ipc_protocol.h b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
index 9b3a6d86ece7..289397c4ea6c 100644
--- a/drivers/net/wwan/iosm/iosm_ipc_protocol.h
+++ b/drivers/net/wwan/iosm/iosm_ipc_protocol.h
@@ -122,7 +122,7 @@  struct iosm_protocol {
 	struct iosm_imem *imem;
 	struct ipc_rsp *rsp_ring[IPC_MEM_MSG_ENTRIES];
 	struct device *dev;
-	phys_addr_t phy_ap_shm;
+	dma_addr_t phy_ap_shm;
 	u32 old_msg_tail;
 };