| Message ID | 20221201101810.56207-1-michal.wilczynski@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2,v2] devlink: Fix setting parent for 'rate add' | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
diff --git a/devlink/devlink.c b/devlink/devlink.c index 150b4e63..11daf0c3 100644 --- a/devlink/devlink.c +++ b/devlink/devlink.c @@ -5049,7 +5049,8 @@ static int cmd_port_fn_rate_add(struct dl *dl) int err; err = dl_argv_parse(dl, DL_OPT_PORT_FN_RATE_NODE_NAME, - DL_OPT_PORT_FN_RATE_TX_SHARE | DL_OPT_PORT_FN_RATE_TX_MAX); + DL_OPT_PORT_FN_RATE_TX_SHARE | DL_OPT_PORT_FN_RATE_TX_MAX | + DL_OPT_PORT_FN_RATE_PARENT); if (err) return err;
Setting a parent during creation of the node doesn't work, despite documentation [1] clearly saying that it should. [1] man/man8/devlink-rate.8 Example: $ devlink port function rate add pci/0000:4b:00.0/node_custom parent node_0 Unknown option "parent" Fix this by passing DL_OPT_PORT_FN_RATE_PARENT as an argument to dl_argv_parse() when it gets called from cmd_port_fn_rate_add(). Fixes: 6c70aca76ef2 ("devlink: Add port func rate support") Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com> --- v2: - Re-send to target iproute2 instead of iproute2-next devlink/devlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)