| Message ID | 20221203094240.1240211-1-liujian56@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4640177049549de1a43e9bc49265f0cdfce08cfd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx() | expand |
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni <pabeni@redhat.com>: On Sat, 3 Dec 2022 17:42:39 +0800 you wrote: > The skb is delivered to napi_gro_receive() which may free it, after > calling this, dereferencing skb may trigger use-after-free. > > Fixes: 542ae60af24f ("net: hisilicon: Add Fast Ethernet MAC driver") > Signed-off-by: Liu Jian <liujian56@huawei.com> > --- > drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net] net: hisilicon: Fix potential use-after-free in hisi_femac_rx() https://git.kernel.org/netdev/net/c/464017704954 You are awesome, thank you!
diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c index 93846bace028..ce2571c16e43 100644 --- a/drivers/net/ethernet/hisilicon/hisi_femac.c +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c @@ -283,7 +283,7 @@ static int hisi_femac_rx(struct net_device *dev, int limit) skb->protocol = eth_type_trans(skb, dev); napi_gro_receive(&priv->napi, skb); dev->stats.rx_packets++; - dev->stats.rx_bytes += skb->len; + dev->stats.rx_bytes += len; next: pos = (pos + 1) % rxq->num; if (rx_pkts_num >= limit)
The skb is delivered to napi_gro_receive() which may free it, after calling this, dereferencing skb may trigger use-after-free. Fixes: 542ae60af24f ("net: hisilicon: Add Fast Ethernet MAC driver") Signed-off-by: Liu Jian <liujian56@huawei.com> --- drivers/net/ethernet/hisilicon/hisi_femac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)