From patchwork Mon Dec 5 10:35:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Divya Koppera X-Patchwork-Id: 13064385 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38363C4321E for ; Mon, 5 Dec 2022 10:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231261AbiLEKgH (ORCPT ); Mon, 5 Dec 2022 05:36:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbiLEKgG (ORCPT ); Mon, 5 Dec 2022 05:36:06 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A06F1400E; Mon, 5 Dec 2022 02:36:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670236566; x=1701772566; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=oTO2yPsusLZgNVgDfp/CBrd6D7AUOQ+evE9FoBeVXSI=; b=c1jQdhLTsNv2jj5zqpGSyG6omwHcQJCjO6255LdbwQonCnJsfYBbkSx3 d8BrXVgpAhI7ONMYUAvszpAHRkt0RixQvy79Z513ixOCNATO1IQ4iRAW6 rAybEaVU6ZPqPRCRRGQVt45lHK4ZaCENpnN1FT+7oxRngJZkUh5e/UxfY Jwbg6AgXkPq5lRlvGTf/T9tpP3ovSL+zappZIY2S6ftp7Sd23iNxYmF/K tDxX/yj+2BWCHqVaDUmzubb/w2gGmvOS41FaZDXiygE78t2A9Sdf2ocqu qBt1yfyezQXSjwkPm+5yzaSK0T07TOVnUGnpNpekVU4jfp9avNAwTtQYd w==; X-IronPort-AV: E=Sophos;i="5.96,219,1665471600"; d="scan'208";a="186538911" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 05 Dec 2022 03:36:05 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Mon, 5 Dec 2022 03:36:03 -0700 Received: from training-HP-280-G1-MT-PC.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.12 via Frontend Transport; Mon, 5 Dec 2022 03:35:59 -0700 From: Divya Koppera To: , , , , , , , , , CC: , Subject: [PATCH v4 net-next 1/2] net: phy: micrel: Fixed error related to uninitialized symbol ret Date: Mon, 5 Dec 2022 16:05:49 +0530 Message-ID: <20221205103550.24944-2-Divya.Koppera@microchip.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221205103550.24944-1-Divya.Koppera@microchip.com> References: <20221205103550.24944-1-Divya.Koppera@microchip.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Initialized return variable Fixes Old smatch warnings: drivers/net/phy/micrel.c:1750 ksz886x_cable_test_get_status() error: uninitialized symbol 'ret'. Reported-by: kernel test robot Reported-by: Dan Carpenter Fixes: 21b688dabecb ("net: phy: micrel: Cable Diag feature for lan8814 phy") Signed-off-by: Divya Koppera Reviewed-by: Andrew Lunn --- v3 -> v4: - Split the patch for different warnings. v1 -> v3: - No changes --- drivers/net/phy/micrel.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 26ce0c5defcd..1bcdb828db56 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -2088,7 +2088,8 @@ static int ksz886x_cable_test_get_status(struct phy_device *phydev, const struct kszphy_type *type = phydev->drv->driver_data; unsigned long pair_mask = type->pair_mask; int retries = 20; - int pair, ret; + int ret = 0; + int pair; *finished = false;