| Message ID | 20221207082213.707577-1-roid@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4de59102f49ff9128378568cf967d6c7aabea6f2 |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2,1/1] tc: ct: Fix invalid pointer dereference | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Wed, Dec 07, 2022 at 09:22:13AM CET, roid@nvidia.com wrote: >Using macro NEXT_ARG_FWD does not validate argc. >Use macro NEXT_ARG which validates argc while parsing args >in the same loop iteration. > >Fixes: c8a494314c40 ("tc: Introduce tc ct action") >Signed-off-by: Roi Dayan <roid@nvidia.com> >Reviewed-by: Paul Blakey <paulb@nvidia.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Hello: This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <stephen@networkplumber.org>: On Wed, 7 Dec 2022 10:22:13 +0200 you wrote: > Using macro NEXT_ARG_FWD does not validate argc. > Use macro NEXT_ARG which validates argc while parsing args > in the same loop iteration. > > Fixes: c8a494314c40 ("tc: Introduce tc ct action") > Signed-off-by: Roi Dayan <roid@nvidia.com> > Reviewed-by: Paul Blakey <paulb@nvidia.com> > > [...] Here is the summary with links: - [iproute2,1/1] tc: ct: Fix invalid pointer dereference https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=4de59102f49f You are awesome, thank you!
diff --git a/tc/m_ct.c b/tc/m_ct.c index a02bf0cc1655..54d64867abcb 100644 --- a/tc/m_ct.c +++ b/tc/m_ct.c @@ -243,7 +243,7 @@ parse_ct(struct action_util *a, int *argc_p, char ***argv_p, int tca_id, return -1; } - NEXT_ARG_FWD(); + NEXT_ARG(); if (matches(*argv, "port") != 0) continue;
Using macro NEXT_ARG_FWD does not validate argc. Use macro NEXT_ARG which validates argc while parsing args in the same loop iteration. Fixes: c8a494314c40 ("tc: Introduce tc ct action") Signed-off-by: Roi Dayan <roid@nvidia.com> Reviewed-by: Paul Blakey <paulb@nvidia.com> --- tc/m_ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)