| Message ID | 20221212035309.33507-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: ksz884x: Remove the unused function port_cfg_force_flow_ctrl() | expand |
On Mon, Dec 12, 2022 at 11:53:09AM +0800, Jiapeng Chong wrote: > The function port_cfg_force_flow_ctrl() is defined in the ksz884x.c file, > but not called elsewhere, so remove this unused function. > > drivers/net/ethernet/micrel/ksz884x.c:2212:20: warning: unused function 'port_cfg_force_flow_ctrl'. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3418 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/net/ethernet/micrel/ksz884x.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c > index e6acd1e7b263..46f1fbf58b5a 100644 > --- a/drivers/net/ethernet/micrel/ksz884x.c > +++ b/drivers/net/ethernet/micrel/ksz884x.c > @@ -2209,12 +2209,6 @@ static inline void port_cfg_back_pressure(struct ksz_hw *hw, int p, int set) > KS8842_PORT_CTRL_2_OFFSET, PORT_BACK_PRESSURE, set); > } > > -static inline void port_cfg_force_flow_ctrl(struct ksz_hw *hw, int p, int set) > -{ > - port_cfg(hw, p, > - KS8842_PORT_CTRL_2_OFFSET, PORT_FORCE_FLOW_CTRL, set); > -} > - > static inline int port_chk_back_pressure(struct ksz_hw *hw, int p) This function is not called too. Many functions in that file can be removed. Please do it in one patch. Thanks > { > return port_chk(hw, p, > -- > 2.20.1.7.g153144c >
diff --git a/drivers/net/ethernet/micrel/ksz884x.c b/drivers/net/ethernet/micrel/ksz884x.c index e6acd1e7b263..46f1fbf58b5a 100644 --- a/drivers/net/ethernet/micrel/ksz884x.c +++ b/drivers/net/ethernet/micrel/ksz884x.c @@ -2209,12 +2209,6 @@ static inline void port_cfg_back_pressure(struct ksz_hw *hw, int p, int set) KS8842_PORT_CTRL_2_OFFSET, PORT_BACK_PRESSURE, set); } -static inline void port_cfg_force_flow_ctrl(struct ksz_hw *hw, int p, int set) -{ - port_cfg(hw, p, - KS8842_PORT_CTRL_2_OFFSET, PORT_FORCE_FLOW_CTRL, set); -} - static inline int port_chk_back_pressure(struct ksz_hw *hw, int p) { return port_chk(hw, p,
The function port_cfg_force_flow_ctrl() is defined in the ksz884x.c file, but not called elsewhere, so remove this unused function. drivers/net/ethernet/micrel/ksz884x.c:2212:20: warning: unused function 'port_cfg_force_flow_ctrl'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3418 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/net/ethernet/micrel/ksz884x.c | 6 ------ 1 file changed, 6 deletions(-)