| Message ID | 20221214080117.3514615-1-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2cb815cfc78b137ee38bcd65e7c955d6cc2cc250 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails | expand |
On Wed, Dec 14, 2022 at 04:01:17PM +0800, Gaosheng Cui wrote: > We should set the return value to -ENOMEM explicitly when > create_singlethread_workqueue() fails in stmmac_dvr_probe(), > otherwise we'll lose the error value. > > Fixes: a137f3f27f92 ("net: stmmac: fix possible memory leak in stmmac_dvr_probe()") > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > v2: > - Change title of this patch to be "PATCH net", thanks! > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + > 1 file changed, 1 insertion(+) > It is so shameful that on Fixed commit, my tag too :(. Sorry about that. Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni <pabeni@redhat.com>: On Wed, 14 Dec 2022 16:01:17 +0800 you wrote: > We should set the return value to -ENOMEM explicitly when > create_singlethread_workqueue() fails in stmmac_dvr_probe(), > otherwise we'll lose the error value. > > Fixes: a137f3f27f92 ("net: stmmac: fix possible memory leak in stmmac_dvr_probe()") > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > [...] Here is the summary with links: - [net,v2] net: stmmac: fix errno when create_singlethread_workqueue() fails https://git.kernel.org/netdev/net/c/2cb815cfc78b You are awesome, thank you!
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index ec64b65dee34..c6951c976f5d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -7099,6 +7099,7 @@ int stmmac_dvr_probe(struct device *device, priv->wq = create_singlethread_workqueue("stmmac_wq"); if (!priv->wq) { dev_err(priv->device, "failed to create workqueue\n"); + ret = -ENOMEM; goto error_wq_init; }
We should set the return value to -ENOMEM explicitly when create_singlethread_workqueue() fails in stmmac_dvr_probe(), otherwise we'll lose the error value. Fixes: a137f3f27f92 ("net: stmmac: fix possible memory leak in stmmac_dvr_probe()") Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- v2: - Change title of this patch to be "PATCH net", thanks! drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1 insertion(+)