diff mbox series

[net,v2] powerpc: dts: t208x: Disable 10G on MAC1 and MAC2

Message ID 20221216172937.2960054-1-sean.anderson@seco.com (mailing list archive)
State Accepted
Commit 8d8bee13ae9e316443c6666286360126a19c8d94
Delegated to: Netdev Maintainers
Headers show
Series [net,v2] powerpc: dts: t208x: Disable 10G on MAC1 and MAC2 | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 19 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Sean Anderson Dec. 16, 2022, 5:29 p.m. UTC 
There aren't enough resources to run these ports at 10G speeds. Disable
10G for these ports, reverting to the previous speed.

Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
Reported-by: Camelia Alexandra Groza <camelia.groza@nxp.com>
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

Changes in v2:
- Remove the 10g properties, instead of removing the MAC dtsis.

 arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

Comments

Camelia Alexandra Groza Dec. 19, 2022, 4:23 p.m. UTC | #1 
> -----Original Message-----
> From: Sean Anderson <sean.anderson@seco.com>
> Sent: Friday, December 16, 2022 19:30
> To: David S . Miller <davem@davemloft.net>; netdev@vger.kernel.org
> Cc: devicetree@vger.kernel.org; Rob Herring <robh+dt@kernel.org>;
> Christophe Leroy <christophe.leroy@csgroup.eu>; Nicholas Piggin
> <npiggin@gmail.com>; Michael Ellerman <mpe@ellerman.id.au>; linuxppc-
> dev@lists.ozlabs.org; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; linux-kernel@vger.kernel.org; Camelia
> Alexandra Groza <camelia.groza@nxp.com>; Sean Anderson
> <sean.anderson@seco.com>
> Subject: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and
> MAC2
> 
> There aren't enough resources to run these ports at 10G speeds. Disable
> 10G for these ports, reverting to the previous speed.
> 
> Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
> Reported-by: Camelia Alexandra Groza <camelia.groza@nxp.com>
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---

Thank you.

Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
Tested-by: Camelia Groza <camelia.groza@nxp.com>

> Changes in v2:
> - Remove the 10g properties, instead of removing the MAC dtsis.
> 
>  arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> index 74e17e134387..27714dc2f04a 100644
> --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> @@ -659,3 +659,19 @@ L2_1: l2-cache-controller@c20000 {
>  		interrupts = <16 2 1 9>;
>  	};
>  };
> +
> +&fman0_rx_0x08 {
> +	/delete-property/ fsl,fman-10g-port;
> +};
> +
> +&fman0_tx_0x28 {
> +	/delete-property/ fsl,fman-10g-port;
> +};
> +
> +&fman0_rx_0x09 {
> +	/delete-property/ fsl,fman-10g-port;
> +};
> +
> +&fman0_tx_0x29 {
> +	/delete-property/ fsl,fman-10g-port;
> +};
> --
> 2.35.1.1320.gc452695387.dirty
Camelia Alexandra Groza Dec. 22, 2022, 3:41 p.m. UTC | #2 
> -----Original Message-----
> From: Camelia Alexandra Groza <camelia.groza@nxp.com>
> Sent: Monday, December 19, 2022 18:23
> To: Sean Anderson <sean.anderson@seco.com>; David S . Miller
> <davem@davemloft.net>; netdev@vger.kernel.org
> Cc: devicetree@vger.kernel.org; Rob Herring <robh+dt@kernel.org>;
> Christophe Leroy <christophe.leroy@csgroup.eu>; Nicholas Piggin
> <npiggin@gmail.com>; Michael Ellerman <mpe@ellerman.id.au>; linuxppc-
> dev@lists.ozlabs.org; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; linux-kernel@vger.kernel.org; Sean
> Anderson <sean.anderson@seco.com>
> Subject: RE: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and
> MAC2
> 
> > -----Original Message-----
> > From: Sean Anderson <sean.anderson@seco.com>
> > Sent: Friday, December 16, 2022 19:30
> > To: David S . Miller <davem@davemloft.net>; netdev@vger.kernel.org
> > Cc: devicetree@vger.kernel.org; Rob Herring <robh+dt@kernel.org>;
> > Christophe Leroy <christophe.leroy@csgroup.eu>; Nicholas Piggin
> > <npiggin@gmail.com>; Michael Ellerman <mpe@ellerman.id.au>; linuxppc-
> > dev@lists.ozlabs.org; Krzysztof Kozlowski
> > <krzysztof.kozlowski+dt@linaro.org>; linux-kernel@vger.kernel.org;
> Camelia
> > Alexandra Groza <camelia.groza@nxp.com>; Sean Anderson
> > <sean.anderson@seco.com>
> > Subject: [PATCH net v2] powerpc: dts: t208x: Disable 10G on MAC1 and
> > MAC2
> >
> > There aren't enough resources to run these ports at 10G speeds. Disable
> > 10G for these ports, reverting to the previous speed.
> >
> > Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
> > Reported-by: Camelia Alexandra Groza <camelia.groza@nxp.com>
> > Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> > ---
> 
> Thank you.
> 
> Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
> Tested-by: Camelia Groza <camelia.groza@nxp.com>

I see the patch marked Not Applicable in the netdev patchwork.
What tree will it go through?

> > Changes in v2:
> > - Remove the 10g properties, instead of removing the MAC dtsis.
> >
> >  arch/powerpc/boot/dts/fsl/t2081si-post.dtsi | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > index 74e17e134387..27714dc2f04a 100644
> > --- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > +++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
> > @@ -659,3 +659,19 @@ L2_1: l2-cache-controller@c20000 {
> >  		interrupts = <16 2 1 9>;
> >  	};
> >  };
> > +
> > +&fman0_rx_0x08 {
> > +	/delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_tx_0x28 {
> > +	/delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_rx_0x09 {
> > +	/delete-property/ fsl,fman-10g-port;
> > +};
> > +
> > +&fman0_tx_0x29 {
> > +	/delete-property/ fsl,fman-10g-port;
> > +};
> > --
> > 2.35.1.1320.gc452695387.dirty
Jakub Kicinski Dec. 22, 2022, 7:08 p.m. UTC | #3 
On Thu, 22 Dec 2022 15:41:00 +0000 Camelia Alexandra Groza wrote:
> > Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
> > Tested-by: Camelia Groza <camelia.groza@nxp.com>  
> 
> I see the patch marked Not Applicable in the netdev patchwork.
> What tree will it go through?

I could be wrong but I think DTS patches are supposed to go via the
platform / arch trees. We mostly take bindings via the networking trees
(and DTS changes if they are part of a larger code+binding+dts set).
But we can obviously apply this patch if that's the preference of
the PowerPC maintainers..
Michael Ellerman Dec. 22, 2022, 11:30 p.m. UTC | #4 
Jakub Kicinski <kuba@kernel.org> writes:
> On Thu, 22 Dec 2022 15:41:00 +0000 Camelia Alexandra Groza wrote:
>> > Reviewed-by: Camelia Groza <camelia.groza@nxp.com>
>> > Tested-by: Camelia Groza <camelia.groza@nxp.com>  
>> 
>> I see the patch marked Not Applicable in the netdev patchwork.
>> What tree will it go through?
>
> I could be wrong but I think DTS patches are supposed to go via the
> platform / arch trees. We mostly take bindings via the networking trees
> (and DTS changes if they are part of a larger code+binding+dts set).
> But we can obviously apply this patch if that's the preference of
> the PowerPC maintainers..

The commit it Fixes went in via the networking tree, so I think it would
make sense for you to take this also via the networking tree.

cheers
Jakub Kicinski Dec. 23, 2022, 1:56 a.m. UTC | #5 
On Fri, 23 Dec 2022 10:30:36 +1100 Michael Ellerman wrote:
> The commit it Fixes went in via the networking tree, so I think it would
> make sense for you to take this also via the networking tree.

Roger that, thanks for confirming.
patchwork-bot+netdevbpf@kernel.org Dec. 23, 2022, 2 a.m. UTC | #6 
Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 16 Dec 2022 12:29:37 -0500 you wrote:
> There aren't enough resources to run these ports at 10G speeds. Disable
> 10G for these ports, reverting to the previous speed.
> 
> Fixes: 36926a7d70c2 ("powerpc: dts: t208x: Mark MAC1 and MAC2 as 10G")
> Reported-by: Camelia Alexandra Groza <camelia.groza@nxp.com>
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> 
> [...]

Here is the summary with links:
  - [net,v2] powerpc: dts: t208x: Disable 10G on MAC1 and MAC2
    https://git.kernel.org/netdev/net/c/8d8bee13ae9e

You are awesome, thank you!
diff mbox series

Patch

diff --git a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
index 74e17e134387..27714dc2f04a 100644
--- a/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t2081si-post.dtsi
@@ -659,3 +659,19 @@  L2_1: l2-cache-controller@c20000 {
 		interrupts = <16 2 1 9>;
 	};
 };
+
+&fman0_rx_0x08 {
+	/delete-property/ fsl,fman-10g-port;
+};
+
+&fman0_tx_0x28 {
+	/delete-property/ fsl,fman-10g-port;
+};
+
+&fman0_rx_0x09 {
+	/delete-property/ fsl,fman-10g-port;
+};
+
+&fman0_tx_0x29 {
+	/delete-property/ fsl,fman-10g-port;
+};