| Message ID | 20221227110352.1436120-1-zhangxuezhi3@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c2052189f19bd98c80b5d46dc6e42330d2b3b35d |
| Headers | show |
| Series | s390/qeth: convert sysfs snprintf to sysfs_emit | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@davemloft.net>: On Tue, 27 Dec 2022 19:03:52 +0800 you wrote: > From: Xuezhi Zhang <zhangxuezhi1@coolpad.com> > > Follow the advice of the Documentation/filesystems/sysfs.rst > and show() should only use sysfs_emit() or sysfs_emit_at() > when formatting the value to be returned to user space. > > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com> > > [...] Here is the summary with links: - s390/qeth: convert sysfs snprintf to sysfs_emit https://git.kernel.org/netdev/net/c/c2052189f19b You are awesome, thank you!
On Wed, Dec 28, 2022 at 12:20:15PM +0000, patchwork-bot+netdevbpf@kernel.org wrote: > Hello: > > This patch was applied to netdev/net.git (master) > by David S. Miller <davem@davemloft.net>: > > On Tue, 27 Dec 2022 19:03:52 +0800 you wrote: > > From: Xuezhi Zhang <zhangxuezhi1@coolpad.com> > > > > Follow the advice of the Documentation/filesystems/sysfs.rst > > and show() should only use sysfs_emit() or sysfs_emit_at() > > when formatting the value to be returned to user space. > > > > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com> > > > > [...] > > Here is the summary with links: > - s390/qeth: convert sysfs snprintf to sysfs_emit > https://git.kernel.org/netdev/net/c/c2052189f19b I'm a little late to the party here, but should the use of sprintf() in show functions elsewhere in the qeth_core_sys.c also be updated?
On 05.01.23 13:02, Simon Horman wrote: > On Wed, Dec 28, 2022 at 12:20:15PM +0000, patchwork-bot+netdevbpf@kernel.org wrote: >> Hello: >> >> This patch was applied to netdev/net.git (master) >> by David S. Miller <davem@davemloft.net>: >> >> On Tue, 27 Dec 2022 19:03:52 +0800 you wrote: >>> From: Xuezhi Zhang <zhangxuezhi1@coolpad.com> >>> >>> Follow the advice of the Documentation/filesystems/sysfs.rst >>> and show() should only use sysfs_emit() or sysfs_emit_at() >>> when formatting the value to be returned to user space. >>> >>> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com> >>> >>> [...] >> >> Here is the summary with links: >> - s390/qeth: convert sysfs snprintf to sysfs_emit >> https://git.kernel.org/netdev/net/c/c2052189f19b > > I'm a little late to the party here, but should the use of sprintf() in > show functions elsewhere in the qeth_core_sys.c also be updated? > Yes, we are working on this. Several patches will come soon, that cleanup whole files. No need to send additional small patches on this topic at the moment.
diff --git a/drivers/s390/net/qeth_core_sys.c b/drivers/s390/net/qeth_core_sys.c index 406be169173c..d1adc4b83193 100644 --- a/drivers/s390/net/qeth_core_sys.c +++ b/drivers/s390/net/qeth_core_sys.c @@ -410,13 +410,13 @@ static ssize_t qeth_dev_isolation_show(struct device *dev, switch (card->options.isolation) { case ISOLATION_MODE_NONE: - return snprintf(buf, 6, "%s\n", ATTR_QETH_ISOLATION_NONE); + return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_NONE); case ISOLATION_MODE_FWD: - return snprintf(buf, 9, "%s\n", ATTR_QETH_ISOLATION_FWD); + return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_FWD); case ISOLATION_MODE_DROP: - return snprintf(buf, 6, "%s\n", ATTR_QETH_ISOLATION_DROP); + return sysfs_emit(buf, "%s\n", ATTR_QETH_ISOLATION_DROP); default: - return snprintf(buf, 5, "%s\n", "N/A"); + return sysfs_emit(buf, "%s\n", "N/A"); } } @@ -500,9 +500,9 @@ static ssize_t qeth_hw_trap_show(struct device *dev, struct qeth_card *card = dev_get_drvdata(dev); if (card->info.hwtrap) - return snprintf(buf, 5, "arm\n"); + return sysfs_emit(buf, "arm\n"); else - return snprintf(buf, 8, "disarm\n"); + return sysfs_emit(buf, "disarm\n"); } static ssize_t qeth_hw_trap_store(struct device *dev,