| Message ID | 20230104181017.2880916-1-elder@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ipa: correct IPA v4.7 IMEM offset | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 6 of 6 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On 4.01.2023 19:10, Alex Elder wrote: > Commit b310de784bacd ("net: ipa: add IPA v4.7 support") was merged > despite an unresolved comment made by Konrad Dybcio. Konrad > observed that the IMEM region specified for IPA v4.7 did not match > that used downstream for the SM7225 SoC. In "lagoon.dtsi" present > in a Sony Xperia source tree, a ipa_smmu_ap node was defined with a > "qcom,additional-mapping" property that defined the IPA IMEM area > starting at offset 0x146a8000 (not 0x146a9000 that was committed). > > The IPA v4.7 target system used for testing uses the SM7225 SoC, so > we'll adhere what the downstream code specifies is the address of > the IMEM region used for IPA. > > Link: https://lore.kernel.org/linux-arm-msm/20221208211529.757669-1-elder@linaro.org > Tested-by: Luca Weiss <luca.weiss@fairphone.com> > Signed-off-by: Alex Elder <elder@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > Note: This fixes a commit that first landed in v6.2-rc1. > > drivers/net/ipa/data/ipa_data-v4.7.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/data/ipa_data-v4.7.c b/drivers/net/ipa/data/ipa_data-v4.7.c > index 7552c400961eb..b83390c486158 100644 > --- a/drivers/net/ipa/data/ipa_data-v4.7.c > +++ b/drivers/net/ipa/data/ipa_data-v4.7.c > @@ -357,7 +357,7 @@ static const struct ipa_mem ipa_mem_local_data[] = { > static const struct ipa_mem_data ipa_mem_data = { > .local_count = ARRAY_SIZE(ipa_mem_local_data), > .local = ipa_mem_local_data, > - .imem_addr = 0x146a9000, > + .imem_addr = 0x146a8000, > .imem_size = 0x00002000, > .smem_id = 497, > .smem_size = 0x00009000,
On Wed, 4 Jan 2023 12:10:17 -0600 Alex Elder wrote:
> Note: This fixes a commit that first landed in v6.2-rc1.
Why is it tagged for net-next then?
On 1/5/23 11:58 PM, Jakub Kicinski wrote: > On Wed, 4 Jan 2023 12:10:17 -0600 Alex Elder wrote: >> Note: This fixes a commit that first landed in v6.2-rc1. > > Why is it tagged for net-next then?
diff --git a/drivers/net/ipa/data/ipa_data-v4.7.c b/drivers/net/ipa/data/ipa_data-v4.7.c index 7552c400961eb..b83390c486158 100644 --- a/drivers/net/ipa/data/ipa_data-v4.7.c +++ b/drivers/net/ipa/data/ipa_data-v4.7.c @@ -357,7 +357,7 @@ static const struct ipa_mem ipa_mem_local_data[] = { static const struct ipa_mem_data ipa_mem_data = { .local_count = ARRAY_SIZE(ipa_mem_local_data), .local = ipa_mem_local_data, - .imem_addr = 0x146a9000, + .imem_addr = 0x146a8000, .imem_size = 0x00002000, .smem_id = 497, .smem_size = 0x00009000,
Commit b310de784bacd ("net: ipa: add IPA v4.7 support") was merged despite an unresolved comment made by Konrad Dybcio. Konrad observed that the IMEM region specified for IPA v4.7 did not match that used downstream for the SM7225 SoC. In "lagoon.dtsi" present in a Sony Xperia source tree, a ipa_smmu_ap node was defined with a "qcom,additional-mapping" property that defined the IPA IMEM area starting at offset 0x146a8000 (not 0x146a9000 that was committed). The IPA v4.7 target system used for testing uses the SM7225 SoC, so we'll adhere what the downstream code specifies is the address of the IMEM region used for IPA. Link: https://lore.kernel.org/linux-arm-msm/20221208211529.757669-1-elder@linaro.org Tested-by: Luca Weiss <luca.weiss@fairphone.com> Signed-off-by: Alex Elder <elder@linaro.org> --- Note: This fixes a commit that first landed in v6.2-rc1. drivers/net/ipa/data/ipa_data-v4.7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)