@@ -1174,12 +1174,20 @@ static void rswitch_mac_config(struct phylink_config *config,
unsigned int mode,
const struct phylink_link_state *state)
{
+ struct net_device *ndev = to_net_dev(config->dev);
+
+ if (mode == MLO_AN_INBAND)
+ netdev_err(ndev, "Link up/down will not work because in-band mode\n");
}
static void rswitch_mac_link_down(struct phylink_config *config,
unsigned int mode,
phy_interface_t interface)
{
+ struct net_device *ndev = to_net_dev(config->dev);
+ struct rswitch_device *rdev = netdev_priv(ndev);
+
+ phy_power_off(rdev->serdes);
}
static void rswitch_mac_link_up(struct phylink_config *config,
@@ -1187,7 +1195,11 @@ static void rswitch_mac_link_up(struct phylink_config *config,
phy_interface_t interface, int speed,
int duplex, bool tx_pause, bool rx_pause)
{
+ struct net_device *ndev = to_net_dev(config->dev);
+ struct rswitch_device *rdev = netdev_priv(ndev);
+
/* Current hardware cannot change speed at runtime */
+ phy_power_on(rdev->serdes);
}
static const struct phylink_mac_ops rswitch_phylink_ops = {
Some Ethernet PHYs (like marvell10g) will decide the host interface mode by the media-side speed. So, the rswitch driver needs to initialize one of the Ethernet SERDES (r8a779f0-eth-serdes) ports after linked the Ethernet PHY up. The r8a779f0-eth-serdes driver has .init() for initializing all ports and .power_on() for initializing each port. So, add phy_power_{on,off} calling for it. Notes that in-band mode will not work because the initialization is not completed. So, output error message if in-band mode. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- drivers/net/ethernet/renesas/rswitch.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)