| Message ID | 20230125143513.25841-1-ihuguet@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ffffd2454a7a1bc9f7242b12c4cc0b05c12692b4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] sfc: correctly advertise tunneled IPv6 segmentation | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net |
| netdev/fixes_present | success | Fixes tag present in non-next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 7 of 7 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | Fixes tag looks correct |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | warning | WARNING: line length of 82 exceeds 80 columns |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Wed, Jan 25, 2023 at 03:35:13PM +0100, Íñigo Huguet wrote: > Recent sfc NICs are TSO capable for some tunnel protocols. However, it > was not working properly because the feature was not advertised in > hw_enc_features, but in hw_features only. > > Setting up a GENEVE tunnel and using iperf3 to send IPv4 and IPv6 traffic > to the tunnel show, with tcpdump, that the IPv4 packets still had ~64k > size but the IPv6 ones had only ~1500 bytes (they had been segmented by > software, not offloaded). With this patch segmentation is offloaded as > expected and the traffic is correctly received at the other end. > > Fixes: 24b2c3751aa3 ("sfc: advertise encapsulated offloads on EF10") > Reported-by: Tianhao Zhao <tizhao@redhat.com> > Signed-off-by: Íñigo Huguet <ihuguet@redhat.com> Acked-by: Martin Habets <habetsm.xilinx@gmail.com> > --- > drivers/net/ethernet/sfc/efx.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c > index 0556542d7a6b..3a86f1213a05 100644 > --- a/drivers/net/ethernet/sfc/efx.c > +++ b/drivers/net/ethernet/sfc/efx.c > @@ -1003,8 +1003,11 @@ static int efx_pci_probe_post_io(struct efx_nic *efx) > /* Determine netdevice features */ > net_dev->features |= (efx->type->offload_features | NETIF_F_SG | > NETIF_F_TSO | NETIF_F_RXCSUM | NETIF_F_RXALL); > - if (efx->type->offload_features & (NETIF_F_IPV6_CSUM | NETIF_F_HW_CSUM)) > + if (efx->type->offload_features & (NETIF_F_IPV6_CSUM | NETIF_F_HW_CSUM)) { > net_dev->features |= NETIF_F_TSO6; > + if (efx_has_cap(efx, TX_TSO_V2_ENCAP)) > + net_dev->hw_enc_features |= NETIF_F_TSO6; > + } > /* Check whether device supports TSO */ > if (!efx->type->tso_versions || !efx->type->tso_versions(efx)) > net_dev->features &= ~NETIF_F_ALL_TSO; > -- > 2.34.3
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 25 Jan 2023 15:35:13 +0100 you wrote: > Recent sfc NICs are TSO capable for some tunnel protocols. However, it > was not working properly because the feature was not advertised in > hw_enc_features, but in hw_features only. > > Setting up a GENEVE tunnel and using iperf3 to send IPv4 and IPv6 traffic > to the tunnel show, with tcpdump, that the IPv4 packets still had ~64k > size but the IPv6 ones had only ~1500 bytes (they had been segmented by > software, not offloaded). With this patch segmentation is offloaded as > expected and the traffic is correctly received at the other end. > > [...] Here is the summary with links: - [net] sfc: correctly advertise tunneled IPv6 segmentation https://git.kernel.org/netdev/net/c/ffffd2454a7a You are awesome, thank you!
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 0556542d7a6b..3a86f1213a05 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c @@ -1003,8 +1003,11 @@ static int efx_pci_probe_post_io(struct efx_nic *efx) /* Determine netdevice features */ net_dev->features |= (efx->type->offload_features | NETIF_F_SG | NETIF_F_TSO | NETIF_F_RXCSUM | NETIF_F_RXALL); - if (efx->type->offload_features & (NETIF_F_IPV6_CSUM | NETIF_F_HW_CSUM)) + if (efx->type->offload_features & (NETIF_F_IPV6_CSUM | NETIF_F_HW_CSUM)) { net_dev->features |= NETIF_F_TSO6; + if (efx_has_cap(efx, TX_TSO_V2_ENCAP)) + net_dev->hw_enc_features |= NETIF_F_TSO6; + } /* Check whether device supports TSO */ if (!efx->type->tso_versions || !efx->type->tso_versions(efx)) net_dev->features &= ~NETIF_F_ALL_TSO;
Recent sfc NICs are TSO capable for some tunnel protocols. However, it was not working properly because the feature was not advertised in hw_enc_features, but in hw_features only. Setting up a GENEVE tunnel and using iperf3 to send IPv4 and IPv6 traffic to the tunnel show, with tcpdump, that the IPv4 packets still had ~64k size but the IPv6 ones had only ~1500 bytes (they had been segmented by software, not offloaded). With this patch segmentation is offloaded as expected and the traffic is correctly received at the other end. Fixes: 24b2c3751aa3 ("sfc: advertise encapsulated offloads on EF10") Reported-by: Tianhao Zhao <tizhao@redhat.com> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com> --- drivers/net/ethernet/sfc/efx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)