| Message ID | 20230201081438.3151-1-liubo03@inspur.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b18ea3d9d214dfb23b0b6bd2acc121cb0d0fa2c5 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: Use sysfs_emit() to instead of sprintf() | expand |
Hello: This patch was applied to netdev/net-next.git (master) by Paolo Abeni <pabeni@redhat.com>: On Wed, 1 Feb 2023 03:14:38 -0500 you wrote: > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > Signed-off-by: Bo Liu <liubo03@inspur.com> > --- > net/dsa/master.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - net: dsa: Use sysfs_emit() to instead of sprintf() https://git.kernel.org/netdev/net-next/c/b18ea3d9d214 You are awesome, thank you!
diff --git a/net/dsa/master.c b/net/dsa/master.c index 26d90140d271..dcbd88fe4281 100644 --- a/net/dsa/master.c +++ b/net/dsa/master.c @@ -299,7 +299,7 @@ static ssize_t tagging_show(struct device *d, struct device_attribute *attr, struct net_device *dev = to_net_dev(d); struct dsa_port *cpu_dp = dev->dsa_ptr; - return sprintf(buf, "%s\n", + return sysfs_emit(buf, "%s\n", dsa_tag_protocol_to_str(cpu_dp->tag_ops)); }
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Bo Liu <liubo03@inspur.com> --- net/dsa/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)