From patchwork Sat Feb 4 17:07:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 13128823 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE4CEC636CC for ; Sat, 4 Feb 2023 17:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230042AbjBDRL7 (ORCPT ); Sat, 4 Feb 2023 12:11:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231987AbjBDRL6 (ORCPT ); Sat, 4 Feb 2023 12:11:58 -0500 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC9132E58 for ; Sat, 4 Feb 2023 09:11:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SQXPtR/YU0K3zY9wQtDOPzHHOqVrT9fIMB3BrFBlZTDDh9lghNT+l9rcumO5SvdPV/SAyexdTN8gQU7KHFLt/E5Batb3rIbuCMWPQ9iBbrBpyZ3Yp81PAcDuYNZEuvDN/xIPXZ4GBGZrplwOpyzYntkpZ0yz7WaUegZASXoruVGKUwj+6VF3uFJhSiaBFfYbx10k0dlxviUihWcgcQWRvDLtcTc+iaoToIfP2YDdKRQG6KzGM+FXuGebA3StRSaG1wAzK/lGwfu8Uo9vJ3gCm5mdkE+NQiHBsbw0jX5au0bHf87qqfYR9de3w7blfO4a3/uAccHVfrBUUWC4QoXlbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=REBoPD/3fQkhdNFrYHOPfbSU4VP8xl+1/rrOSS6EpiM=; b=As6vhzxWfh1LJHprse45sgMui96vqP+j6kTHjwBzz8jCzDpSDpXdGuyGQAmvYL5NSRqu7zfv/Bm87ByFAGB86fiMK28Xx+kAg1q0RqwyMp5fsmUTaUII/L5GBViH2NGKpfoT/6F5sqxywzMNJkKXUP5tk8WiTd3lvLRfBdreHqlUKK2zeaeT/6JZgW0Tr7MCIoNlBz3ooHHPoJexHrbe3AwpA9Pv9qmmunY6J6LJKs6LOykMvF5VhFxw5sGI62F3ahVsD/kTAtJ+ThUk8EIbpo+FEuS2FbKKOUU8i9R3Ag3x7MZhk0oLOz2d+cdc7sx7c9VPQxB3H6/tCI2MzfUuQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=REBoPD/3fQkhdNFrYHOPfbSU4VP8xl+1/rrOSS6EpiM=; b=Xpe75xFXp7TfciZj62RfnS5pOJlCDkoe7MrQ4MmSMTbacWdaOso8dwAcNtHWWYU144MuNNqOdM1L6O5TfXXHgdNFvCB2QKM+edQBVkKJMbnipr+gxQpKCjnDk+640ScMro6i6mvxqNOXGTt9pg7BBXLzL9kKGLWTz7nTByBqowg1BtTyrHNIPFJFdbW2enEm1hG8FzPTcowG0Di9nucHRiMYzpnBjd1mgBDptTktnGIjBu67vvNBfe6juOWIHvtZewWsv4lzQ71QAAArg5uEL0hL05z9VE+nC7phqjjBwzrHrTcHDeQpuq14AGTIml4cLbtvM5zEIRikH0XrrvmXJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6179.namprd12.prod.outlook.com (2603:10b6:930:24::22) by SA3PR12MB7997.namprd12.prod.outlook.com (2603:10b6:806:307::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31; Sat, 4 Feb 2023 17:11:53 +0000 Received: from CY5PR12MB6179.namprd12.prod.outlook.com ([fe80::7d2c:828f:5cae:7eab]) by CY5PR12MB6179.namprd12.prod.outlook.com ([fe80::7d2c:828f:5cae:7eab%9]) with mapi id 15.20.6064.025; Sat, 4 Feb 2023 17:11:52 +0000 From: Ido Schimmel To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, razor@blackwall.org, roopa@nvidia.com, petrm@nvidia.com, mlxsw@nvidia.com, Ido Schimmel Subject: [RFC PATCH net-next 02/13] bridge: mcast: Remove pointless sequence generation counter assignment Date: Sat, 4 Feb 2023 19:07:50 +0200 Message-Id: <20230204170801.3897900-3-idosch@nvidia.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20230204170801.3897900-1-idosch@nvidia.com> References: <20230204170801.3897900-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR07CA0257.eurprd07.prod.outlook.com (2603:10a6:803:b4::24) To CY5PR12MB6179.namprd12.prod.outlook.com (2603:10b6:930:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6179:EE_|SA3PR12MB7997:EE_ X-MS-Office365-Filtering-Correlation-Id: 1a4eed0e-1d4c-41b8-2497-08db06d2e928 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CblcSWtyufgvS3iOU9E1Gsr9OGV+t74dKhsbIS9S9grepzSFAyHzGxKkMm7NqueHDGHFFSggoNkCX8AForWZlW2QOWaLFkpdVHirJXUv2coVj2Mnpszdir+awQK/qqS5YyrGczWH1kiDRsUMz97Sbqrs6BZaexDk9OlSSRGn1n7n36/75aLk+gX3Byt7x84ZD0s2XGrhJwcFOlv9MxfBpfcsWPjSMYTuku+y5sUdOe7NPdPiouVbM9PdlQ26jLdqeXggsbUmL3aHCGTUnnXycxRUaxfCmqUoSuMgoF5+zO25CdSlQ4kmmMO4BlxuY/lsez2fMOLbBODKSUfz32TjO5IITbM2ys7R108Va22bsoKka4lREpFROiZ09x6PmFMhZLUp4hIhEDLIhLFzk/1/mHkNW5sHfd5w3h0r4nCTCT//0J9Ta60sgmEzrP2TUySqbMJ+o83Z2bkZiINzYdA4TPGBESJadpNzs/qprSCsVr/rxvJXwq49ocRzaZwMyqQIGHYXoi8Z2KrP0HFfb/d9bX0+abUGco6hyEae6gthkhwNLTYHLAejFKNbJ3pq6vCrHuMHrkBIwUXTAs1arPHSmZMo2zrrsK1pbX0H9qamt49daoAEo4ANPojuN3g65PRKagxqMnKp/1kKMvmc/B3eng== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6179.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(451199018)(8676002)(41300700001)(66556008)(316002)(66946007)(36756003)(66476007)(6486002)(1076003)(26005)(186003)(478600001)(6506007)(6512007)(4326008)(107886003)(38100700002)(2906002)(86362001)(8936002)(5660300002)(83380400001)(2616005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7d8DgBNvFJ7yv8aOs0TWnKuX7Kof8N52g3DVq/wZ1qEs8pNbsglSGDe1ivnbdHlWb3FpWtS5CMsHIExNpWeFGfDmZlQ10tjfAkf5w730Yng6NM55NxDVwnQ+4YP38oR7COyTnBVXC9UCPPnGUo9rPkFYkm31P4EniRO1ijVV7fglu+RI0Knv77fhvZ6X6FkADcVM2uqiOcjj8gOBvswiKqsyLJMYQPIkXpoVK5HIuvRhDdSs21Ks/Mikh1dv5n2YJVewwP21y6qai2i9qfuYnskLx2hsli21ISKSOH9i/yPnokQtE0M5AgHssohcn2QKNsa9BPdB2kgqPGzZq89bNVSNOVv7vSv4o+VsU1VkmJIyxLTLV+BrLFprJkf4Yn6dgNonh75vQfzND1BXXBDMGsS8zRnZfIH1wh9QqZoPdNbzDaiHmzK+BLUMsEEArRhrG1K+/w912z3G7ObJYz+gdPbK7E+s8qYIY7K4dAy8CF3Pk+bMAmNyq9uXj9HMU+GFkCA7a6NzadoNCSYs9lTQi6A3eoHiyMp1MQy5zpBWdmTvnOX3zN+qyzH6LDxpbjPwv/NITmtYDIKrHa5xryFswB+mUblxTLWIrVZulLUYXoA0FXS59aHkRYr3hbjTLbbD+BB0cwsovXejN4OV5K/ojaaEfvuiPz5P6pkOcvxMmx/n1nvgi3rSVbA61CSZjO/5Wcf3Bm5xPuZL8jJtkr7YUlzgF7RXz5sqhztBn+LpjutZqOHlrem/Et/PcHswWVtRIOK0/hft+yLExISBL586tA3m3edSGKdEpd9dsjdyw8CZLtwePIyuadNLbeaA9W2kzPKBdwkhzRUi8t22GjUEGuhL4RoL/pHNwTXn1jlNWCYPzJh/Y3Fln54G6WAYyiWfm0yCNam/D+d/0eaSiD3MaxIK5gNTHU9v9JuUQMy5nut6XF0xqRgVxqYc4iMXWENgGT5fgN+VxiLKjWuEon+IuWbavuY78RgVrluKcYPtHapLhsoXCZJE+81X8o/x/FHP4BBI/qqGJJFQFDzvKGjEEqo29QUP0vrN6g+T9yFPWefqc7zYK9kvTDPfdHsSa2aRkhunLG18UrzFpm+NiBJhUrextNJyf6guRjzV2r65OpZZnGLdiu+znBv9/aUvfqyqAPbhzhRHUcF5Zsou/xhgYwNguOk9uzC+YitG+YmI0bO2dF8uiTBIpbpETCd9K9IKFP4YCuO3sZs+g5KWhBuZusvsFHOVCjtAC/EJqF6rmaCP2JGNHsAnllKREWK+zT6uW2lOhoRXKtkzET8xWdwGEKyxjru6/UOTNKVShuSV3sNfehYhTNJvmr5ep9iSa1bT3RIqdB6YtKY5xU/9u8pQGbhnNReh7EMwWjWA3kStjG0j3udgEsOdzvBKugPnlXMF1SYk4cHrPujs09+hnFUicYbCLAqMrcCgJhWJCCMPnj2PRyRWLCxIBe5tsJo0aujPPtXXUSRor0q85KkUztkMf587pWtQy/rLVdjPdcS0DwxMCylWQqV3xs6c9/lSZsHPJWUCJNQWL13g+5WO8cuWVFFwllfDM3I2PjxJ3rBO3Tvx80dOhq1RuIEud5wNPpMH X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a4eed0e-1d4c-41b8-2497-08db06d2e928 X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2023 17:11:52.8772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6PFia00cxrq3wRHRQYvoRSOU2iDdwN6enMpgicnXNNeiuEqbteJxpnDz3ERXxGY22SwsA0JR1uPij6CjaK5sQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7997 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org X-Patchwork-State: RFC The purpose of the sequence generation counter in the netlink callback is to identify if a multipart dump is consistent or not by calling nl_dump_check_consistent() whenever a message is generated. The function is not invoked by the MDB code, rendering the sequence generation counter assignment pointless. Remove it. Note that even the function was invoked, we still could not accurately determine if the dump is consistent or not, as there is no sequence generation counter for MDB entries, unlike nexthop objects, for example. Signed-off-by: Ido Schimmel --- net/bridge/br_mdb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index fc98c32e5894..e40a4c275d63 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -421,8 +421,6 @@ static int br_mdb_dump(struct sk_buff *skb, struct netlink_callback *cb) rcu_read_lock(); - cb->seq = net->dev_base_seq; - for_each_netdev_rcu(net, dev) { if (netif_is_bridge_master(dev)) { struct net_bridge *br = netdev_priv(dev);