| Message ID | 20230206131620.2758724-33-mkl@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9cf670dbe69d11c6f29284aa80d78741f038ecd4 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,01/47] can: gw: give feedback on missing CGW_FLAGS_CAN_IIF_TX_OK flag | expand |
diff --git a/drivers/net/can/dev/bittiming.c b/drivers/net/can/dev/bittiming.c index 32af609eee50..5e111dbbe090 100644 --- a/drivers/net/can/dev/bittiming.c +++ b/drivers/net/can/dev/bittiming.c @@ -39,7 +39,7 @@ static int can_fixup_bittiming(const struct net_device *dev, struct can_bittimin return -EINVAL; bt->bitrate = priv->clock.freq / (bt->brp * can_bit_time(bt)); - bt->sample_point = ((tseg1 + 1) * 1000) / can_bit_time(bt); + bt->sample_point = ((CAN_SYNC_SEG + tseg1) * 1000) / can_bit_time(bt); return 0; }
Commit 1c47fa6b31c2 ("can: dev: add a helper function to calculate the duration of one bit") made the constant CAN_SYNC_SEG available in a header file. The magic number 1 in can_fixup_bittiming() represents the width of the sync segment, replace it by CAN_SYNC_SEG to make the code more readable. Link: https://lore.kernel.org/all/20230202110854.2318594-3-mkl@pengutronix.de Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> --- drivers/net/can/dev/bittiming.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)