| Message ID | 20230206142152.4183995-1-idosch@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e7baae08a90115cbfe28785da9b97193f0a36a1e |
| Delegated to: | Stephen Hemminger |
| Headers | show |
| Series | [iproute2-next] bridge: mdb: Remove double space in MDB dump | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 2/6/23 16:21, Ido Schimmel wrote: > There is an extra space after the "proto" field. Remove it. > > Before: > > # bridge -d mdb > dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1 > > After: > > # bridge -d mdb > dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1 > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > --- > bridge/mdb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bridge/mdb.c b/bridge/mdb.c > index f323cd091fcc..9b5503657178 100644 > --- a/bridge/mdb.c > +++ b/bridge/mdb.c > @@ -221,7 +221,7 @@ static void print_mdb_entry(FILE *f, int ifindex, const struct br_mdb_entry *e, > __u8 rtprot = rta_getattr_u8(tb[MDBA_MDB_EATTR_RTPROT]); > SPRINT_BUF(rtb); > > - print_string(PRINT_ANY, "protocol", " proto %s ", > + print_string(PRINT_ANY, "protocol", " proto %s", > rtnl_rtprot_n2a(rtprot, rtb, sizeof(rtb))); > } > } Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Hello: This patch was applied to iproute2/iproute2.git (main) by Stephen Hemminger <stephen@networkplumber.org>: On Mon, 6 Feb 2023 16:21:52 +0200 you wrote: > There is an extra space after the "proto" field. Remove it. > > Before: > > # bridge -d mdb > dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1 > > [...] Here is the summary with links: - [iproute2-next] bridge: mdb: Remove double space in MDB dump https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=e7baae08a901 You are awesome, thank you!
diff --git a/bridge/mdb.c b/bridge/mdb.c index f323cd091fcc..9b5503657178 100644 --- a/bridge/mdb.c +++ b/bridge/mdb.c @@ -221,7 +221,7 @@ static void print_mdb_entry(FILE *f, int ifindex, const struct br_mdb_entry *e, __u8 rtprot = rta_getattr_u8(tb[MDBA_MDB_EATTR_RTPROT]); SPRINT_BUF(rtb); - print_string(PRINT_ANY, "protocol", " proto %s ", + print_string(PRINT_ANY, "protocol", " proto %s", rtnl_rtprot_n2a(rtprot, rtb, sizeof(rtb))); } }
There is an extra space after the "proto" field. Remove it. Before: # bridge -d mdb dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1 After: # bridge -d mdb dev br0 port swp1 grp 239.1.1.1 permanent proto static vid 1 Signed-off-by: Ido Schimmel <idosch@nvidia.com> --- bridge/mdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)