| Message ID | 20230208024333.10465-2-kerneljasonxing@gmail.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v4,1/3] ixgbe: allow to increase MTU to 3K with XDP enabled | expand |
On Wed, 2023-02-08 at 10:43 +0800, Jason Xing wrote: > From: Jason Xing <kernelxing@tencent.com> > > Include the second VLAN HLEN into account when computing the maximum > MTU size as other drivers do. > > Fixes: 0c8493d90b6b ("i40e: add XDP support for pass and drop actions") > Signed-off-by: Jason Xing <kernelxing@tencent.com> > --- > v2: drop the duplicate definition > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 53d0083e35da..d039928f3646 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -2921,7 +2921,7 @@ static int i40e_change_mtu(struct net_device *netdev, int new_mtu) > struct i40e_pf *pf = vsi->back; > > if (i40e_enabled_xdp_vsi(vsi)) { > - int frame_size = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN; > + int frame_size = new_mtu + I40E_PACKET_HDR_PAD; > > if (frame_size > i40e_max_xdp_frame_size(vsi)) > return -EINVAL; Looks good to me. Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
>-----Original Message----- >From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of >Jason Xing >Sent: 08 February 2023 08:14 >To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L ><anthony.l.nguyen@intel.com>; davem@davemloft.net; >edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >richardcochran@gmail.com; ast@kernel.org; daniel@iogearbox.net; >hawk@kernel.org; john.fastabend@gmail.com; Lobakin, Alexandr ><alexandr.lobakin@intel.com>; Fijalkowski, Maciej ><maciej.fijalkowski@intel.com> >Cc: kerneljasonxing@gmail.com; netdev@vger.kernel.org; linux- >kernel@vger.kernel.org; intel-wired-lan@lists.osuosl.org; >bpf@vger.kernel.org; Jason Xing <kernelxing@tencent.com> >Subject: [Intel-wired-lan] [PATCH net v2 2/3] i40e: add double of VLAN header >when computing the max MTU > >From: Jason Xing <kernelxing@tencent.com> > >Include the second VLAN HLEN into account when computing the maximum >MTU size as other drivers do. > >Fixes: 0c8493d90b6b ("i40e: add XDP support for pass and drop actions") >Signed-off-by: Jason Xing <kernelxing@tencent.com> >--- >v2: drop the duplicate definition >--- > drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worker at Intel)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 53d0083e35da..d039928f3646 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -2921,7 +2921,7 @@ static int i40e_change_mtu(struct net_device *netdev, int new_mtu) struct i40e_pf *pf = vsi->back; if (i40e_enabled_xdp_vsi(vsi)) { - int frame_size = new_mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN; + int frame_size = new_mtu + I40E_PACKET_HDR_PAD; if (frame_size > i40e_max_xdp_frame_size(vsi)) return -EINVAL;