From patchwork Thu Feb 9 07:18:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 13134096 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A83CCC61DA4 for ; Thu, 9 Feb 2023 07:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229478AbjBIHVG (ORCPT ); Thu, 9 Feb 2023 02:21:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjBIHVF (ORCPT ); Thu, 9 Feb 2023 02:21:05 -0500 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2080.outbound.protection.outlook.com [40.107.92.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEFCB442C0 for ; Wed, 8 Feb 2023 23:20:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cqvzOI7vendGyHE/fPapmHb6IcMUBDcz6MAMcQMTuWqulOUBF82PVUn0ChI5E+YEafKDgHNUuPmTXDwM4N4REVlu6GWWkunaLSCTChROms6VvZLYp4wVsWsZ2F4W5rzFh7lzB2c3UigslbVz0N6moMeK4qjpDjQ2ejz9eiMLulzauvVcnv8qSru26XcbostmHJU1adF0c6lghfgxeAhAAQvg/0K/OPJPYM8xITOKjsh3fClbwAbkwaK/4hp6H6s9Ec4WgogPQ4qmwZkiP1J/zsuMNWymgNmNrS+DOcoW0UIFdzAR0xChrpoucHvv6sRI/LCd3JuyY4jjt3B8mv96JQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H/6+UXKKZ2rpYAaCAv+LG7aAv+9rhlrWlu74D+hcCj8=; b=fq1J/i/gK3P4zKlzRcx7TIV/qu31QrLgHjTXj6Ce36304DUEF0r6GM/fWKeP7iGaajV0/yuE8EZNWAPIA52Bg1X0PdeJp9HvD0p/4UN8kWldIo131XjvIue407BhPnApv+5j1EkrSe0BWmJR7Ju6GDBMNsGk92MV8vimbCavZW23sZBeh8Ly86Zrzu8wG9N5X5NhJGXF5a5vJdxyz061qAX4qW5MKyeQSSjrGhXowzP8Z2YJkw+L70Sy6WtBJav5tssv/53BIDAAAgYgIfJ8fPiFi23luafWVV5M+UgM41IAGvyaz0sfSZWVKvlr7yo7VVGNf+jrFlttOC27m4LxAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H/6+UXKKZ2rpYAaCAv+LG7aAv+9rhlrWlu74D+hcCj8=; b=HfvunNxH99N67atjuhvx551EyOJpUK1uV+f3DzMdbo/tmfPcsTWt1WisEHkXyLLzTShepmJ8Ueo1EsBQ3EClXmNjJ0F9eAtpEmOvLSi2qKA/malGa8LcoKMcxyxMvhXjvnER46dSdtkkenyRdAjyHYZARseHdBXCjy7iy0XLaobxTBxMHHvrEQB2nGToFEYaB7oQP/fZmxTlJq7bBmeadrG5s7tDvx/g21U+HuVZ7dG+0y4a2deFEeMV2fw8wsFN0iNU1k36fObxAHcRvaL4ffx/PRFnt6OisMybNBNI+UCsJUE/hBiCQdMMHJwKG0C6oGXEPtKNfSgRAb9Biffgxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY5PR12MB6179.namprd12.prod.outlook.com (2603:10b6:930:24::22) by CY8PR12MB7755.namprd12.prod.outlook.com (2603:10b6:930:87::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.17; Thu, 9 Feb 2023 07:19:46 +0000 Received: from CY5PR12MB6179.namprd12.prod.outlook.com ([fe80::7d2c:828f:5cae:7eab]) by CY5PR12MB6179.namprd12.prod.outlook.com ([fe80::7d2c:828f:5cae:7eab%9]) with mapi id 15.20.6064.035; Thu, 9 Feb 2023 07:19:46 +0000 From: Ido Schimmel To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, razor@blackwall.org, roopa@nvidia.com, petrm@nvidia.com, mlxsw@nvidia.com, Ido Schimmel Subject: [PATCH net-next 2/4] bridge: mcast: Remove pointless sequence generation counter assignment Date: Thu, 9 Feb 2023 09:18:50 +0200 Message-Id: <20230209071852.613102-3-idosch@nvidia.com> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20230209071852.613102-1-idosch@nvidia.com> References: <20230209071852.613102-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR03CA0043.eurprd03.prod.outlook.com (2603:10a6:803:50::14) To CY5PR12MB6179.namprd12.prod.outlook.com (2603:10b6:930:24::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY5PR12MB6179:EE_|CY8PR12MB7755:EE_ X-MS-Office365-Filtering-Correlation-Id: ebbec40b-6280-4da8-cbc8-08db0a6e05e9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j0ZmxB0lpZMVk6nyTCIxl4WbXv8p0nPYteWQmjBqVGYfTz9WXfhUMWxKnw8a+1Nh4Q/gOB5Oog3f+91c6jwhX6L1/5dw39m6hhB8pKTeZEE73T/wy2C/4HaXgq2zGub5l1Cg1rTCYVqX9ORPLn7s/UY1tzIuBgZr47g5silluTB7IY7y91tXvTEJeWPLiUtlK19wFiygFs2mPSZx77Bgi1LU+/nC9etz8sdcJmKPVOK5mE1UrZsHkKo3gMfatvfM6c5MiPcNjSF7OhxdJXksvl6BzJaQ+OjW2O3WBpi7pLnvUnXhQnlOt99R7cSGHuQx8PzPZlpV68+T71o27Yp7dezyE0Y8d4+IDhaRy+iE9vT1o2xuPqDnw96rjzsej8d7s7yPyokkUWzJ5uVGbdFok8UTu46lrymHPveav5VJy8KAoXN652QJnVS3m4tArYQnNFvOTpJjxhBUz0M2Ir9CIzAYEIoBumU3coyXtVhIqmlT0UJyZ48aSrpzYzeVi9wcGQR3ZGMeM4cVAj/C4vp3xwy6+JccqOgk9keGIPDgvAeIobQHmH/MOxOYvOgo0TzW91GweCQZCOpSRtZ3JjvyyrEbV4R7djKMufnmJIs1+qjswub8U56qaEwhzo72i4KaqqssnhSv9hxLATqnF7zcWQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY5PR12MB6179.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(366004)(39860400002)(396003)(346002)(451199018)(6512007)(2906002)(186003)(6506007)(1076003)(26005)(36756003)(107886003)(6666004)(5660300002)(478600001)(6486002)(8936002)(41300700001)(2616005)(8676002)(66946007)(4326008)(66476007)(83380400001)(66556008)(86362001)(38100700002)(316002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: VDV+aE2sEKrDGw+sKq7K7dzdTAjvgUBfkrR5DDr1l6klrL7kbAwn24Rq/KAAwygfPXNACrNJoaJmXd6JOEKc5rZbw13fNjF7ysPtKawtlWfYXmytjON/7Pa/RhUSO6cuy64yfLh5BlRmMP+FQeFfcFJ6twi97zbQrsaEU48llGttIk9zrNhDfnGQ5fTbUZiulYfd5ecPnJ4Sw3/ksidLixvQNPE/gtMYKD2gGpq2xkUygbVAb9Z3YYhrF1VA01Cq5PqX9Pe7NgtH/iOq+ndv+4VzCD/dt3RkO9gxzpCW+TsKEUdT1wH6N+QJC1j3Vo6F03rD7Lz3kbjXGGr4+Tse1qwW/NrDBDxCDMuw6eglmIfjc9lM/7LdfetxGIx1mUxNLmZ3NdxiGmJyGymx9Z56/iOfUTsyhAQX8H9+IE3bGsqrRhM4++40sB/eZQ6MWdbcoy3c5qCgBRt7aK/P0yjdt6Vvata/fTmnD5LGZyzO3/Ud8WhY4L+SUreFtXZEsKrjAzsOMGLcaMJU3nUx+oqVUAXJ/ryFg1mJjU0XpwM9ehoj/dN3QM7RhC26FfA40wI27QTMd9Kv9tcO//2fiAFByMYQHxYxIwe/hCLYLzLsnU2I+sn6aRcg8OT8Ft85iNSeqjyzgpqnyq6ux1eZo7XaU9m/EHfJy5FQCoy5t8zqHNUdKNCAZnhpD9f+CmtzNlI+ky2tBOkL8e3w2sMvg9IvY/3H90gT0kRCjDFnKSUmPEX9XX+2kOR0BV0sy6omqT1I0dtmrROwDY67EoXfV+4Ms6qbjHfuGEg7QV7u9K0bW+qBQmcRQ1MztQTjetON8h7gN9JMY9YaVPGSxb8kO0ccdp40xVF2ZLWJKGPT/+xoRIwMD9zE6sNXUKmFpRQrQ2ap3m61KCZcSpVcVANS5dbFOObRK6Z3R613xAua+XS8fw5K6tREE2H83JVqs1wY5avL7jREiE3lBGbidUr//1LgOjUlFaAmSvNE44ABglxPG7RBLz2DAxWcQDmyyIAQ0O0xRkfXQ2QbFm3nQ7xQ9fzTlAyPu1gEBP38XDEzSMRzcmCDt3GkX/dovNED1Ejxa/z1S/iASPQgKEWtG+xVgA2f5WjOpqbOwIlg9stqKYwICVvzrU+0SUMJoQGGZdEH9Av7za+yT7wUmh3uyFj+LePnJ4b5RYFZ58uB8Ek9JW4WTkM8cAeLuEJv/b7rPStNDxJxXogfbh7TC+UyUJR2tNfUa/S8B1zLspwuwTEBkm62qSSlXuRUn9hJ+6nG1KIR0AjeUQ6BZxZiNcZyn8CMwiNrL04ZhsSgSZBh/XZOFtob9URSj8P/iCxy8WO+MTSIaOMVp6SOETRTLiXzXZsjQNMMLGlmP8apq+1itCgFnkEPYZ8eUaJ/coBIKHV+UC8JdgFnZi+yxpw9tgpsLjjDLSvWz34JcRnhw8JYbWoKib203bARiK7Wz2bcVMwjrlDrTTxrNxBskwx6IEffM5NFKRfjDoMYkzN9D7kn77zx9Q0O8htHn+SS8vkDinjwso5Sc0PX+uxCs13S5dy08jJ/3lM4BEObgxaNjrM9HxjPeDUIQnki0c0xI4i88ddpu/23XBC4 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebbec40b-6280-4da8-cbc8-08db0a6e05e9 X-MS-Exchange-CrossTenant-AuthSource: CY5PR12MB6179.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2023 07:19:46.6195 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +XoOmWf6BIkyI01Q57FRx55vdCh6Kmwh1zw1C2AIOuyrQWxCYeQBcIbh9gJiAuyV/Fd0sTR7TatLcPeHY+E0Cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7755 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The purpose of the sequence generation counter in the netlink callback is to identify if a multipart dump is consistent or not by calling nl_dump_check_consistent() whenever a message is generated. The function is not invoked by the MDB code, rendering the sequence generation counter assignment pointless. Remove it. Note that even if the function was invoked, we still could not accurately determine if the dump is consistent or not, as there is no sequence generation counter for MDB entries, unlike nexthop objects, for example. Signed-off-by: Ido Schimmel Acked-by: Nikolay Aleksandrov --- net/bridge/br_mdb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index 13076206e497..96f36febfb30 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -421,8 +421,6 @@ static int br_mdb_dump(struct sk_buff *skb, struct netlink_callback *cb) rcu_read_lock(); - cb->seq = net->dev_base_seq; - for_each_netdev_rcu(net, dev) { if (netif_is_bridge_master(dev)) { struct net_bridge *br = netdev_priv(dev);